Repository navigation
docs(cbio): publish plaintext vectors only, never masked bytes - #167
Closed
shroominic wants to merge 1 commit into
Closed
shroominic wants to merge 1 commit into
shroominic wants to merge 1 commit into
Conversation
The vector table printed the authentication frame's plaintext hex, whose bytes 9..24 are the 16-byte link credential, and the masked column was derived from the real stream key. Both contradict the record's own stated policy and belong to the material tracked in #164. Keep the plaintext layouts, omit the credential field, and generate masked bytes at run time from injected material instead.
This was referenced Sep 18, 2026
Owner
Author
|
Carried by the GS1 consolidation in PR #209 (branch feature/cbio-gs1, head 3eca4f4). This PR is contained in the consolidated line; the merge that carries it is c85f827. Closing as subsumed by the consolidation - not as won't fix. The per-defect evidence stays in this thread, and the carrying commit above is where the change now lives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #164. Applies to #138, which is where the second copy of the material lives. Base is
docs/cbio-gs1-auth-material.What was wrong
The "Synthetic test vectors" table in
docs/testing/cbio-gs1-auth-material.mdprinted two things this record promises not to print:9..24are the 16-byte link credential written out verbatim;The same document says the material is "deliberately not reproduced as bare constants in this document beyond the test vectors above", so it contradicted itself, and it does so on a public branch.
What this changes
19 01 00 <6 reversed address octets> <16-byte material> C.Verification
The byte-class inventory used across this gate derives its needles from the pre-fix source and scans every branch tip, stripping whitespace so a multi-line byte list is matched as well as a hex string. It finds:
docs/cbio-gs1-auth-material,origin/release/v0.4.0, andrepro/162-aggregate-append, before this change;docs/cbio-auth-material-redaction, after it.The only long values left in the redacted document are the artifact digests and one state-changing activation plaintext, neither of which carries key-derived bytes.
Decisions taken
Not claimed
This does not clean the already-published copies of the material in the repository's git history, and it does not touch the byte-list constants on the other sensor branches. Purging or rotating those is a separate owner decision, requested in #173.