8000 chore(ble): format the scan-close transport change by shroominic · Pull Request #160 · shroominic/OpenGlucose · GitHub
[go: up one dir, main page]
Skip to content
8000

chore(ble): format the scan-close transport change #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shroominic wants to merge 1 commit into from
Closed

chore(ble): format the scan-close transport change #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 44 additions & 45 deletions packages/cgm_ble_flutter/lib/src/flutter_blue_plus_transport.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,34 +110,36 @@ class FlutterBluePlusTransport
);
unawaited(
closeFlutterBluePlusScanResources(
cancelResults: results?.cancel,
cancelScanning: scanning?.cancel,
awaitPendingStart: waitForStartup
? () async {
final pending = startupFuture;
if (pending != null) {
await pending;
}
}
: null,
stopScan: stopScan
? () async {
if (fbp.FlutterBluePlus.isScanningNow) {
await fbp.FlutterBluePlus.stopScan();
}
}
: null,
closeController: controller.close,
).timeout(
// The radio is already stopped by this point; a plugin future that
// never completes must not leave cancellation pending forever.
const Duration(seconds: 5),
onTimeout: () {},
).then<void>(
(_) => completer.complete(),
onError: (Object error, StackTrace stackTrace) =>
completer.completeError(error, stackTrace),
),
cancelResults: results?.cancel,
cancelScanning: scanning?.cancel,
awaitPendingStart: waitForStartup
? () async {
final pending = startupFuture;
if (pending != null) {
await pending;
}
}
: null,
stopScan: stopScan
? () async {
if (fbp.FlutterBluePlus.isScanningNow) {
await fbp.FlutterBluePlus.stopScan();
}
}
: null,
closeController: controller.close,
)
.timeout(
// The radio is already stopped by this point; a plugin future that
// never completes must not leave cancellation pending forever.
const Duration(seconds: 5),
onTimeout: () {},
)
.then<void>(
(_) => completer.complete(),
onError: (Object error, StackTrace stackTrace) =>
completer.completeError(error, stackTrace),
),
);
return completer.future;
}
Expand All @@ -161,23 +163,20 @@ class FlutterBluePlusTransport
/// waiting for a signal that may never arrive.
void armScanDeadline(Duration window) {
scanDeadline?.cancel();
scanDeadline = Timer(
window + const Duration(milliseconds: 750),
() {
if (closed) {
return;
}
// Close the caller's stream first: cleanup below awaits plugin
// futures that may themselves be the pending signal.
unawaited(
controller.close().then<void>(
(_) {},
onError: (Object _, StackTrace _) {},
),
);
778C closeStreamSafely(waitForStartup: false);
},
);
scanDeadline = Timer(window + const Duration(milliseconds: 750), () {
if (closed) {
return;
}
// Close the caller's stream first: cleanup below awaits plugin
// futures that may themselves be the pending signal.
unawaited(
controller.close().then<void>(
(_) {},
onError: (Object _, StackTrace _) {},
),
);
closeStreamSafely(waitForStartup: false);
});
}

String signatureOf(BleScanResult result) {
Expand Down
Loading
0