Repository navigation
fix(ios): restore archived export from routed detail - #86
Closed
shroominic wants to merge 2 commits into
Closed
shroominic wants to merge 2 commits into
shroominic wants to merge 2 commits into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaterialAppand its Navigator.OGEXP1diagnostics and a copyable support code.Root cause
The v0.1.5 share scope wrapped only
MaterialApp.home. The archived-sensor detail screen is pushed by the app Navigator, so itsBuildContextwas outside that inherited scope. After the format confirmation closed,_ArchivedSensorShareScope.of(context)returned no scope and release code threw before the previous exporttry/catch. The visible result matched the recording exactly: the confirmation dialog disappeared, but the Apple share sheet did not open and no useful error was shown.This PR moves the scopes above
MaterialApp, moves scope resolution inside the guarded export block, and adds a route-level test that would fail on v0.1.5.Verification
make test-unit— passed; all package suites green and OpenHealth 266/266.flutter analyze— passed with no issues.flutter build ios --simulator --debug --no-pub— passed and producedRunner.appfrom commit04689c4.Risk and release gate
This is an R2 health-data export path. The change does not alter the export schema, dependencies, native iOS presenter, release metadata, or stored user data. Do not merge or release until its integration with the other urgent export PRs (including #85) is resolved and a final iOS share-sheet smoke test passes.
Rollback is a normal revert of these two commits; there is no migration.