Repository navigation
[pull] main from miniflux:main - #352
Merged
Merged
Conversation
strings.Split("", ",") returns [""], so an empty tag configuration
attached a single empty-string tag to every bookmark saved through the
Raindrop integration. Split the configured tags with SplitSeq, trim
whitespace, drop empty items, and omit the tags field entirely from the
payload when no tags are configured.
Pool.Shutdown() closed the job queue channel, but jobs can still be pushed while workers are draining: the feed scheduler ticker goroutine is never cancelled, and the UI and API refresh handlers push from detached goroutines that outlive the HTTP server shutdown. Any of them sending on the closed queue panicked the process mid-shutdown. Keep the queue channel open and instead close a dedicated shutdown channel, guarded by sync.Once. Push now selects between delivering a job and the shutdown signal, discarding jobs once shutdown begins, and workers select between the queue and the shutdown signal, so they still finish their current job before Shutdown returns.
The showChooseSubscriptionPage handler never set hasProxyConfigured on the view, so when the add_subscription template was re-rendered after a validation or feed creation error, the fetch_via_proxy checkbox silently disappeared from the form. Set the flag during view setup, matching the other subscription handlers.
getTranslationDict lazily populates the package-level defaultCatalog map and runs on concurrent request goroutines via template functions, flash messages, and error translation. Two concurrent requests for languages not yet cached triggered Go's fatal "concurrent map writes" and killed the daemon. Guard the catalog with a sync.RWMutex using double-checked locking so each language is loaded once. A failed load is no longer cached as an empty dictionary, so unknown languages now return the error on every call; both callers treat an error and an empty dictionary identically, so rendered output is unchanged. Add a regression test exercising concurrent lazy population; it fails under the race detector on the previous implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )