8000 [pull] main from miniflux:main by pull[bot] · Pull Request #350 · suhaoGe/miniflux · GitHub
[go: up one dir, main page]

Skip to content

[pull] main from miniflux:main - #350

Merged
pull[bot] merged 1 commit into
suhaoGe:mainfrom
miniflux:main
Jul 20, 2026
Merged

pull[bot] merged 1 commit into
suhaoGe:mainfrom
miniflux:main

Conversation

@pull
@pull pull Bot commented Jul 20, 2026 •
Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

The GET /v1/icons/{iconID} endpoint fetched icons by their internal
numeric identifier without any user scoping, allowing any authenticated
user to enumerate icon IDs and read favicon data associated with feeds
owned by other users on the same instance.

Rename IconByID to IconByUserAndIconID and gate the lookup on an EXISTS
check against feeds owned by the requesting user, so unauthorized icon
IDs return 404. Add integration tests covering cross-user access and
inexisting icon IDs.
@pull pull Bot locked and limited conversation to collaborators Jul 20, 2026
844F
@pull pull Bot added the ⤵️ pull label Jul 20, 2026
@pull
pull Bot merged commit 4d84eee into suhaoGe:main Jul 20, 2026
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0