Repository navigation
[pull] main from miniflux:main - #346
Merged
Merged
Conversation
The remove_tables rule unwrapped each table element by appending its inner HTML to the end of the parent node and then removing the element. Any content located after the table (and the table content itself) was therefore moved to the bottom of the entry instead of staying in place, which reordered the article. Replace the append-then-remove with an in-place ReplaceWithHtml so the unwrapped content keeps its original document order. The existing TestRewriteRemoveTables still passes because its content is fully nested in a single root table; a new test with content surrounding the table covers the regression. Fixes #3110 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
8445
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )