Repository navigation
[pull] main from miniflux:main - #341
Merged
Merged
Conversation
Entries without their own language now take the feed-level value, matching the behaviour introduced for Atom. For JSON Feed this is spec-mandated: an item declares a language only when it differs from the primary language of the feed. For RSS and RDF, items are part of the channel's content, and API consumers previously saw an empty entries.language even when the channel declared one. The RSS channel now also reads <dc:language>: hybrid feeds commonly declare the channel language via Dublin Core instead of <language>.
9C36
Render bound per-request, language-specific functions (t, plural, elapsed) onto the shared template before executing it. Doing that while other goroutines execute the same template races on its function map and can render a response using another request's language. Clone the template before binding those functions so each request executes its own copy. Fixes #4380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )