Repository navigation
[pull] main from miniflux:main - #334
Merged
Merged
Conversation
The single-entry endpoint proxified enclosure URLs while the list endpoints did not, so the same enclosure was returned with different URLs depending on the endpoint used.
The mark-user-as-read and integrations-status handlers treated any error from UserByID as a 404, which masked genuine database failures and never detected a missing user since UserByID returns no error when the user does not exist. Return a server error on failure and a not found response only when the user is nil.
The current-user and categories handlers used the value returned by UserByID without checking whether it was nil. Since UserByID returns no error when the user does not exist, the categories handler could dereference a nil user. Return a not found response when the user is nil.
The update-feed handler returned a not found response for any error from FeedByID, masking genuine database failures. Return a server error on failure and keep the not found response for a nil feed.
The admin user lookup handlers reported a database error from UserByID and UserByUsername as a bad request with a generic message. Return a server error instead, consistent with the other user handlers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )