Repository navigation
[pull] main from miniflux:main - #302
Merged
Merged
Conversation
The middleware (*authMiddleware).validateApiKey is registered for 14 routes in NewHandler. Its body was just `return http.HandlerFunc(func…)`, which made the compiler consider it inlinable. As a result, the entire losure body was duplicated at every call site, taking space in the .text section. Move the request-handling logic into a separate non-inlined method serveValidated and keep validateApiKey as a thin wrapper that only allocates the http.HandlerFunc. The 14 duplicated symbols are gone and the stripped binary shrink 8000 s from 20,513,033 to 20,447,497 bytes, which isn't that much, but it's still something, especially for such a simple commit.
errors.Is unwraps nested error. This makes check less error prone.
The icons table is deduplicated by hash and shared with feeds via the feed_icons junction. When a feed is deleted, the ON DELETE CASCADE removes its feed_icons row but leaves the icons row behind. The same happens in StoreFeedIcon when a feed's icon is replaced. Over time these orphaned bytea blobs accumulate and bloat the database. Add Storage.CleanupOrphanIcons, which deletes icons rows that no feed_icons row still references, and call it from runCleanupTasks.
Change "unable to get save entry" to "unable to save entry" in the wallabag createEntry error message and its corresponding test assertion.
Remove the username-based WebAuthn login flow because it allowed username enumeration before password verification. WebAuthn login now uses discoverable credentials only, and new registrations require resident keys. Existing non-resident credentials are no longer usable for first-factor login; they should only be used in a post-password MFA flow, which Miniflux does not currently implement. BREAKING CHANGE: Users with existing non-resident WebAuthn credentials must register a new passkey.
Store WebAuthn backup eligibility and backup state with each credential instead of overwriting BackupEligible from every login assertion. Use a nullable backup_eligible column to identify legacy credentials and backfill those records on their next successful login. Also persist the validated credential state after login, including sign count, clone warning, and backup state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )