Repository navigation
[pull] main from miniflux:main - #299
Merged
Merged
Conversation
The function strings.Fields will allocate every single word it's creating, meaning that for a text of 10k words, 10k allocations will be made, only for them to be counted an discarded. We can do much better by counting the words ourself via a small countWords helper function, and write a test to prove that it doesn't allocate anything.
Account unlinking mutates state, so /oauth2/{provider}/unlink can no
longer be reached via GET. Pull the OAuth2/OIDC and WebAuthn sections
out of the settings form and render each as its own fieldset above the
form, with the unlink action as a self-contained POST form. Rename
the username/password fieldset legend to "Password Authentication" and
add matching legends for the federated and passkey sections so all
authentication methods read consistently.
While both deleteCredential either validate or pass down a uid, saveCredential doesn't. This isn't exploitable as an authenticated attacker would need to guess the 32 bytes handle of another one, but it doesn't hurt to explicitly check if a user is only operating on their own user.
The web session middleware redirects unauthenticated requests to the login page before any non-public handler runs, so request.UserID is guaranteed non-zero in beginRegistration, finishRegistration, and deleteCredential. Remove the dead checks to match the other WebAuthn handlers.
Drop the snake_case cred_uid, fix the missing-n typos in webAuthUser and webAuthCredential, replace credCredential with validatedCredential, unify uid/userID on userID, rename the shadowed url local in newWebAuthn to baseURL, and use the full credential / credentials names throughout instead of the abbreviated cred / creds. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )