Repository navigation
[pull] main from miniflux:main - #284
Merged
Merged
Conversation
The previous implementation iterated over entries and issued one DELETE per row as a workaround to avoid a long-running transaction when removing feeds with many entries. In practice this caused N+1 round-trips and took over 3 minutes to delete a feed with 22k entries. Rely on the ON DELETE CASCADE on entries.feed_id (and transitively enclosures.entry_id) and issue a single DELETE on feeds. Postgres handles large cascaded deletes efficiently with row-level locking. Also fix grammar, accuracy, and a missing godoc comment across the exported functions in feed.go.
The integrations table lacked a foreign key to users, forcing RemoveUser to delete integration rows explicitly and RemoveUserAsync to iterate over feeds to avoid a long-running transaction. Add a migration introducing the missing ON DELETE CASCADE foreign key and drop both workarounds. The sole caller of RemoveUserAsync inlines the goroutine so the fire-and-forget behaviour is visible at the call site. Also fix godoc comments in user.go.
Previously CategoriesWithFeedCount loaded the user via UserByID just to read CategoriesSortingOrder. Pass it in explicitly so the UI path (which already has the user loaded) avoids a redundant lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )