Repository navigation
[pull] main from miniflux:main - #238
Merged
Merged
Conversation
8000
Instead of parsing the HTML once in findSubscriptionsFromWebPage and another time in findCanonicalURL, do it once in a `parseHTMLDocument` function. This was also the opportunity to restrict the `link[rel='canonical' i` query to `head link[rel='canonical' i`.
Right after `originalFeed.CheckedNow()`, `originalFeed.ScheduleNextCheck` is called, with its second argument being `refreshdelay`, a time.Duration set to its implicit default value. The variable `refreshdelay` is never reassigned, until much deeper in the function. This commit replaces it with `time.Duration(0)`, to make it explicit that no special delay is expected, and declares it later in a restricted scope.
1. If the websiteURL is equal to the RootURL, there is no need to check them both. 2. Group the icon-looking-queries into a single one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )