8000 [pull] main from miniflux:main by pull[bot] · Pull Request #236 · suhaoGe/miniflux · GitHub
[go: up one dir, main page]
Skip to content

[pull] main from miniflux:main #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 1 commit into from
Feb 15, 2026
Merged
8000

[pull] main from miniflux:main #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions internal/reader/encoding/encoding_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import (
"os"
"testing"
"unicode/utf8"

"golang.org/x/text/encoding/charmap"
)

func TestCharsetReaderWithUTF8(t *testing.T) {
Expand Down Expand Up @@ -346,3 +348,84 @@ func TestNewReaderWithUTF8DocumentWithMetaAfter1024Bytes(t *testing.T) {
t.Fatalf("Data does not contain expected unicode string: %s", expectedUnicodeString)
}
}

func TestCharsetReaderWithKOI8RLabel(t *testing.T) {
expectedUnicodeString := "Привет мир"

input, err := charmap.KOI8R.NewEncoder().Bytes([]byte(expectedUnicodeString))
if err != nil {
t.Fatalf("Unable to build KOI8-R input: %v", err)
}

reader, err := CharsetReader("koi8-r", bytes.NewReader(input))
if err != nil {
t.Fatalf("Unable to create reader: %v", err)
}

data, err := io.ReadAll(reader)
if err != nil {
t.Fatalf("Unable to read data: %v", err)
}

if !utf8.Valid(data) {
t.Fatalf("Data is not valid UTF-8")
}

if string(data) != expectedUnicodeString {
t.Fatalf("Data does not match expected unicode string, got %q expected %q", string(data), expectedUnicodeString)
}
}

func TestCharsetReaderWithUppercaseKOI8RLabel(t *testing.T) {
expectedUnicodeString := "Привет мир"

input, err := charmap.KOI8R.NewEncoder().Bytes([]byte(expectedUnicodeString))
if err != nil {
t.Fatalf("Unable to build KOI8-R input: %v", err)
}

reader, err := CharsetReader("KOI8-R", bytes.NewReader(input))
if err != nil {
t.Fatalf("Unable to create reader: %v", err)
}

data, err := io.ReadAll(reader)
if err != nil {
t.Fatalf("Unable to read data: %v", err)
}

if !utf8.Valid(data) {
t.Fatalf("Data is not valid UTF-8")
}

if string(data) != expectedUnicodeString {
t.Fatalf("Data does not match expected unicode string, got %q expected %q", string(data), expectedUnicodeString)
}
}

func TestNewCharsetReaderWithKOI8RContentType(t *testing.T) {
expectedUnicodeString := "Привет мир"

input, err := charmap.KOI8R.NewEncoder().Bytes([]byte(expectedUnicodeString))
if err != nil {
t.Fatalf("Unable to build KOI8-R input: %v", err)
}

reader, err := NewCharsetReader(bytes.NewReader(input), "text/xml; charset=koi8-r")
if err != nil {
t.Fatalf("Unable to create reader: %v", err)
}

data, err := io.ReadAll(reader)
if err != nil {
t.Fatalf("Unable to read data: %v", err)
}

if !utf8.Valid(data) {
t.Fatalf("Data is not valid UTF-8")
}

if string(data) != expectedUnicodeString {
t.Fatalf("Data does not match expected unicode string, got %q expected %q", string(data), expectedUnicodeString)
}
}
Loading
0