Repository navigation
Decision log: drop a duplicated 2026-11-01 entry - #144
Merged
Merged
Conversation
…ntry The entry appeared twice: once at the top of the 11-01 group, once between the 10-30 entries, byte-identical (md5 deec7cd7 for both). It came from my merge of #132's branch into #138 (bf07e36), which moved the entry back to the top while git also kept it where the other side had it. Only the copy out of place is removed; no entry's text changes. Checked: grep counts the entry's heading once (was twice). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is a straightforward documentation cleanup that only deletes a byte-identical duplicate decision-log entry while leaving the remaining canonical entry and all other content unchanged, with no active issues noted.
No open issues 🎉
What changed in this PR
This pull request removes a byte-identical duplicate decision-log entry so docs/decisions.md contains a single canonical 2026-11-01 — The live camera preview… record, without altering any remaining entry text.
Changes:
- Deleted the out-of-place duplicate copy of the
2026-11-01decision entry. - Left the remaining entry (and all other entries) unchanged.
| File | Summary |
|---|---|
docs/decisions.md |
Removes the duplicated 2026-11-01 “live camera preview” decision entry while preserving all other content verbatim. |
Review effort: Balanced
rleibman
added a commit
that referenced
this pull request
Nov 3, 2026
Conflict only in docs/decisions.md: both 2026-11-02 entries kept, the embedding point's on top; the 11-01 camera-preview entry appears once (#144). #143 and #144 are Apple code and docs, so the GTK (144) and Android (95) counts measured on this branch stand. Checked here: sbt scalafmtAll, Test/compile and platforms/Test/compile, 0 errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-11-01 entry "The live camera preview: the owner took every recommendation in §17.8" is in
docs/decisions.mdtwice, byte-identical. The second copy is the one out of place, among the 10-30 entries. This PR removes that copy; no entry's text changes.Cause: my merge of #132's branch into #138 (
bf07e36). I moved the entry back to the top, but git also kept it where the other side had put it. I didn't check for a duplicate afterwards.Checked:
grep -cfinds the heading once now; before this change it found it twice.Not changed: a few other entries are out of date order (an 11-01 entry among the 10-30 entries), because PRs merged in a different order than they were written. Moving them would mean rewriting more of an append-only file, so I've left them.
Doesn't conflict with #142 or #143; both only add entries at the top of the log.
🤖 Generated with Claude Code