Repository navigation
Accept printed supplier labels: 1 % charge limit (#93) - #96
Merged
Merged
Conversation
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
Accept printed supplier labels: 1 % charge limit (#93)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93 (owner decision 2026-10-23: 1 %).
Problem
A supplier label is checked against its chemical by its charge balance. The limit was 0.1 %, so Yara's printed YaraLiva Calcinit label (N-NO3 14.4 %, N-NH4 1.1 %, CaO 26.3 % = Ca 18.80 %) was refused at -0.565 %. Rounding the printed values alone can move the balance by up to 0.44 %; the rest is the commercial grade not being the pure salt.
Change
materials._CHARGE_RESIDUAL_LIMIT_PERCENT), now the single value used by both supplier grades and materials defined by formula or ions (material_chemistryimported its own copy).identity_inconsistent).USER_GUIDE.mderror table and CHANGELOG updated.Behaviour changes to note
Validation
503 tests with live PHREEQC required; strict Sphinx build clean;
tools/verify_distribution.pyPASS; LF.