Repository navigation
fix: validate custom products before batch chemistry - #243
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 115
Lines 13717 13736 +19
Branches 2715 2721 +6
=========================================
+ Hits 13717 13736 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom batch records could crash input handling or silently change chemistry when two products shared a name. Valid products beginning with
test_were also rejected as placeholders.Preserve existing malformed-reagent error text while adding entry details. Actual unfinished formulas and invalid assays remain rejected. Update regressions and unreleased documentation; solver controls, tolerances and package version are unchanged.
Closes #240
Closes #241
Closes #242
Evidence
test_KNO3andtest_KH2PO4rejected the recipe. After: both product orders retain the control recipe's accounting and pH direction.Merge Danger
Door: two-way
Revertible code and regression-test changes; no data migration.
Blast Radius: inputs
Batch and mix callers with duplicate product names must provide distinct names. Valid distinct-name custom inputs remain supported. This PR does not create a release.