Repository navigation
fix: resolve EC evidence and chemistry provenance audit findings - #247
Open
rafatahmed wants to merge 2 commits into
Open
rafatahmed wants to merge 2 commits into
rafatahmed wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #244. Closes #245. Closes #246.
P1 preserves the disputed 1.2 mS/cm brochure value without selecting a replacement. P2 documents reproducible versioned PHREEQC extraction, retaining database_sha256 as the base-file alias. P4 aligns the README and current publication drafts.
The original MINTEQ database, both extension files, 197 aqueous records and 28 phases are unchanged. Chemistry JSON changes are provenance metadata only. P3 is verification only; P5 remains separate.
Evidence
After: regression checks cover unsupported positive/mixed doses, unchanged zero-dose/other-anchor behavior, tampered inputs/manifests, and deterministic generation.
Merge Danger
Door: two-way
Reversible code/documentation changes; no database replacement, deployment or release.
Blast Radius: Screening
Consumers must handle unsupported manufacturer screening for positive Magsul doses. Provenance schema becomes 2 while preserving the legacy base hash. No chemistry constants or P5 evidence change. This does not establish physical validation or authorize merging.