Repository navigation
fix: preserve Windows accented input and navigation - #235
Merged
Merged
Conversation
rafatahmed
marked this pull request as ready for review
November 7, 2026 13:15
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 115 115
Lines 13510 13550 +40
Branches 2664 2674 +10
=========================================
+ Hits 13510 13550 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 7, 2026
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
fix: preserve Windows accented input and navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows
flahax mixtreating à as an extended-key prefix and consuming the following character. Read native Unicode key events while retaining navigation, editing and held-key repeats.Closes #127.
Evidence
After: the same regression passes. Native records cover à/H/P/K/M text entry, all four arrows, Home/End, Tab/Shift+Tab, Enter, Backspace, Escape, repeats, Alt+numpad release and ignored events. The real mix widgets retain the text and select the expected option.
Native tests inject records into a real hidden Windows console. No physical keyboard-layout or interactive Windows Terminal trial is claimed. POSIX input handling is unchanged; native Linux/macOS checks belong to hosted CI.
Merge Danger
Door: Two-way
Blast Radius: Input
The Windows input adapter changes; the legacy stream decoder remains available for compatibility. No solver, formula, catalogue or numerical-tolerance changes.