Repository navigation
fix: report precipitation by evidence, never refuse for saturation (G12-G14) - #223
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 13186 13111 -75
Branches 2599 2570 -29
=========================================
- Hits 13186 13111 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rafatahmed
marked this pull request as ready for review
November 5, 2026 23:25
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
fix: report precipitation by evidence, never refuse for saturation (G12-G14)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221
Summary
Documentation (
water-to-delivery.mdsaturation section, five more pages), changelog, 0.7.0 notes and the glossary ("Phase information") are updated.Evidence
ph_adjustmentwasblocked(no_acceptable_reagent); every candidate was rejected with "precipitation risk at the target pH: Hydroxylapatite SI 4.04 (blocks); MnHPO4 SI 3.29 (blocks); Vivianite SI 0.18 (blocks)".After:
ph_adjustmentisrequires_reviewwith a reagent selected; the three phases arechemistry.information, MnHPO4 with the basis "unmeasured constant (Plummer et al. 1976 program data)". At--ph 6.5brushite reads SI 0.16 and the warning is "The recipe carries a precipitation risk: CaHPO4:2H2O SI 0.16."tests/test_precipitation_report.py(batch runs) and a rewrittentests/test_saturation_policy.py(12 tests);tests/test_phase_applicability.pyis deleted because every test in it exercised the removed evidence inputs. About 25 older tests that asserted the refusal now assert the report; none was weakened beyond the removed behaviour.test_file_headersexcluded because of a stray untracked.venvon this machine), and a scoped coverage run of the touched modules shows no uncovered changed line or branch. The exact three-OS gate runs in CI.Merge Danger
Door: one-way for API and file consumers.
Removed: the
blocks,blocking,review,thermodynamic,applicability,mixing_approvedandinvalid_solidskeys, theconditions,evidenceandsi_uncertaintyparameters, and theprecipitation_riskrejection. Anything readingsummary.chemistry.blocking/revieworstatuses.phase == "blocked"must readrisk/informationinstead.Blast Radius: results and API
blockedon saturation now select a reagent. Overall status can still readblockedfor other reasons (for example Lettuce 2 needs three tanks, which is a later change).qualification_linesno longer prints an EC qualifier line when a warning already states it. This is not in the spec; without it the notes view printed the same sentence twice once the reagent was selected (test_notes_once).irrigation_ec("X supersaturated ... no kinetic interpretation") are unchanged; the EC rework belongs to the next change.