Repository navigation
ci: light gate on pull requests, full gate before a release - #220
Closed
rafatahmed wants to merge 3 commits into
Closed
rafatahmed wants to merge 3 commits into
rafatahmed wants to merge 3 commits into
Conversation
…docs-only changes, update the contract test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Required check names are unchanged (
test (3.11),test (3.12),test (3.13),phreeqc-live,coverage-gate), so branch protection needs no edit. Decision recorded indocs/adr/0002-light-pull-request-gate.md.Evidence
coverage-gatebecause the Codecov token is empty for Dependabot.After (measured on this PR's first run): the test step took 346 s on Linux 3.13, 455 s on 3.12 and 575 s on 3.11, with no coverage; the Codecov upload runs only in the full tier. No end-to-end time for the whole gate is claimed yet; it is measured below once the run finishes.
tests/test_ci_workflow.py(7 tests) and the existingtest_ci_coveragecontract test pass locally; ruff clean. The contract test failed on the first light run because it still listed the oldneedsand matrix, and is updated here.publish.yml.Merge Danger
Door: two-way. Reverting this one file restores the old gate.
Blast Radius: CI
publish.yml, andbuildwaits for it. A coverage gap found then stops the publication until it is fixed. Thepublish.ymlchange cannot be exercised before a release.strict: truestill reruns every open PR after any merge.