Repository navigation
Alpha TUI round 2 and release hardening for 0.6.0 - #148
Merged
Merged
Conversation
After the results screen closes, print the same grower summary as the line mode (status and reasons, tanks with grams, the acid) before the Wrote line.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 89.83% 89.84%
=======================================
Files 54 54
Lines 7322 7323 +1
=======================================
+ Hits 6578 6579 +1
Misses 744 744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 23, 2026
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
Alpha TUI round 2: fixes from the owner's trial of flahax mix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second trial round of the full-screen
flahax mix. Every problem found in this round gets its own issue and a fix on this branch, with a "Closes" line below. Please keep testing, and merge once the round is done.Fixes so far
test_run_tui_end_to_endchecks that the lines printed after the screen equal the line mode's summary for the same batch; it failed before the fix.Release hardening (pre-release audit for 0.6.0)
The audit covered the build and metadata, the shipped files, every entry point with malformed input, security of saved files, a strict lint pass, CI coverage, the docs and the open issues. Fixed here:
water_shareas text,limitsas a list) or a confusing message ('spec', an acid string read letter by letter).check_sessionnow names the file and the field; the new error codeinvalid_sessionis in the user guide. A malformed-input sweep of all entry points now gives 0 tracebacks.windows-latestandmacos-latest. The Linux jobs keep the check names that branch protection requires.SECURITY.mdandCODE_OF_CONDUCT.mdare now included, with a test.The audit found nothing to change in:
$FLAHAX_HOME;Checks
ruff checkandruff format --checkpass.Owner check
Reinstall from this branch:
Then run
flahax mix, finish a batch and press Q, then Y. The tanks, the grams and the acid should stay in the terminal.Closes #147
Closes #149
Closes #150
Closes #151