Repository navigation
Pre-release sweep fixes: acid formula, repeated notes, formula title - #115
Merged
Merged
Conversation
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
Pre-release sweep fixes: acid formula, repeated notes, formula title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #112.
Closes #113.
Closes #114.
Found by the pre-release sweep of
flahax mixon main: 19 farmer sessions (both of the owner's sessions, fill and one-irrigation modes, RO/well/chloride-free/meq-unit waters, ticked stores, a Calcinit label, a 20-20-20 data sheet, changed and new formulas, no acid, typos, high ratio in the cold, a bad acid formula), each automatically checked across terminal, sheet at depths 1-3, report and summary (weights, acid, pH path, repeated notes, '0 g').flahax mixnow asks again ('FlahaX plans with these acids only: HNO3, H3PO4, H2SO4, C6H8O7'), accepts any case ('hno3'), andflahax batch --acidstops with that list; assay and density are range-checked.formula_title) and used as the title.After the fixes all 19 sweep sessions are clean; the four that block do so for the right, stated reason (79 % imbalance, strengite at pH 5.8, no acid offered, potassium sulfate not dissolving at 200:1 and 8 °C).
525 tests with live PHREEQC required;
tools/verify_distribution.pyPASS; LF.