Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get(0)throws a TypeError on a new empty list or afterconsume()drains it. This affects bothBufferListandBufferListStream, while an end index on a nonempty list already returnsundefined.Treat
index === lengthas out of range before looking up an internal buffer. Add a separate Tape test for both classes, with boundary and append/reuse controls. The same final fixture executes all 12 new assertions on pristine code: four empty-list checks fail and eight controls pass; all 12 pass with the fix.Validation on Node 26.5.0, macOS arm64:
npm run build, fullnpm run test:ci(Standard, Tape, generated types and TypeScript checks), syntax checks andgit diff --checkpass. Generated tracked files remain unchanged. Other Node versions and operating systems were not run.