8000 ci: raise v3 size budget and fix Rust 1.100 lint by adityamukho · Pull Request #891 · project-minigraf/minigraf · GitHub
[go: up one dir, main page]
Skip to content

ci: raise v3 size budget and fix Rust 1.100 lint - #891

Merged
adityamukho merged 2 commits into
v3from
ci/v3-size-1250
Nov 14, 2026
Merged

ci: raise v3 size budget and fix Rust 1.100 lint#891
adityamukho merged 2 commits into
v3from
ci/v3-size-1250

Conversation

@adityamukho
@adityamukho adityamukho commented Nov 13, 2026 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Accommodate the v3 CI failures exposed by the Rust 1.100 update:

  • Raise the enforced distribution-binary budget from 1,240 KiB to the approved 1,250 KiB (1,280,000 bytes). The gate still fails for any byte above the limit; synchronize the documented budget.
  • Simplify optimizer::reorder() so test-enabled builds return the thread-local switch directly, satisfying clippy::needless_bool. Builds without test hooks still return true; behavior is unchanged.

The last successful base build measured 1,239 KiB with Rust 1.99.1; PR #890's build measured 1,242 KiB after CI moved to Rust 1.100.0 and a newer runner image, with identical production source and compiled package versions.

Validation:

  • The workflow's actual size-check shell step accepts 1,271,808 and 1,280,000 bytes, and rejects 1,280,001 bytes.
  • cargo fmt -- --check, cargo clippy --all-features -- -D warnings, and default-feature Clippy pass locally (Rust 1.94; GitHub verifies Rust 1.100).
  • All 47 optimizer unit tests pass with test-hooks, including thread isolation, nested guards, and source-order preservation.
  • Claude reviewed both changes with no blocking findings; git diff --check passes.
  • On commit ec7dc39f, GitHub's native lint job, both WASM Clippy jobs, and the binary-size gate pass.

Targets v3; the main budget and build profiles are unchanged. Separate from the lock-workflow fixes in #889/#890.

@codecov
codecov Bot commented Nov 13, 2026
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adityamukho adityamukho changed the title ci: raise v3 binary-size budget to 1250 KiB ci: raise v3 size budget and fix Rust 1.100 lint Nov 13, 2026
@adityamukho
adityamukho merged commit 75b8326 into v3 Nov 14, 2026
19 checks passed
@adityamukho
adityamukho deleted the ci/v3-size-1250 branch November 14, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adityamukho
0