Repository navigation
fix: INT-001 for a user function that calls its own transaction (minigraf#886) - #19
Merged
Merged
Conversation
A transaction's execute holds its mutex for the whole statement, so a user function of that statement that called execute, commit or rollback on the same transaction locked it again on the same thread and hung. The transaction now records the thread running its statement and refuses a call from that thread with INT-001 before locking; a call from another thread still waits for the statement. Refs project-minigraf/minigraf#886 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2a7QoSuGUZLujRE5TqLKJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user function that called
execute,commitorrollbackon the write transaction whose statement was running it hung: the transaction'sexecuteholds its mutex for the whole statement, and the call locked it again on the same thread.The transaction now records the thread running its statement and refuses a call from that thread with
INT-001before locking, as minigraf-node already does. A call from another thread still waits for the statement.minigraf_tx_rollbackreturns -1 in that case (it returned -1 only for NULL before);minigraf.his regenerated.Tests: the new tests hung before the fix (30 s guard) and pass with it. Codex review (gpt-6-astra): no findings.
Refs project-minigraf/minigraf#886
🤖 Generated with Claude Code
https://claude.ai/code/session_01H2a7QoSuGUZLujRE5TqLKJ