Repository navigation
Tags
Tags
[release-branch.go1.17] modfile: in SetRequireSeparateIndirect, conve… …rt lines to blocks When reading go.mod, SetRequireSeparateIndirect will insert new requirements into the last uncommented direct-only or indirect-only block OR line. If the last such statement is a line, SetRequireSeparateIndirect converts it to a block before inserting new requirements. Cleanup will convert it back to a line later if no requirements are inserted. For golang/go#47756 Change-Id: Id8ee3b0ce2d005488ddb3d9a5349115bd93938e7 Reviewed-on: https://go-review.googlesource.com/c/mod/+/348576 Trust: Jay Conrod <jayconrod@google.com> Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> (cherry picked from commit 37dd689) Reviewed-on: https://go-review.googlesource.com/c/mod/+/351318
zip: add bit more information about what checkFiles does This CL adds a headstone to checkFiles in the form of additional documentation, which should hopefully help future developers. Change-Id: I7957766fc78da45007cbb4e7e3ed59ad2bada4c5 Reviewed-on: https://go-review.googlesource.com/c/mod/+/338669 Trust: Jean de Klerk <deklerk@google.com> Run-TryBot: Jean de Klerk <deklerk@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
modfile: add SetRequireSeparateIndirect The new method is a variant of SetRequire, but adds new indirect dependencies only in indirect-only blocks, and does not add new direct dependencies to existing indirect-only blocks. For golang/go#45965 Change-Id: I6730b586396658e710e4bf2afcf64fb2c827203f Reviewed-on: https://go-review.googlesource.com/c/mod/+/325971 Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org>
module: allow '+' in package import paths (but not module paths) For golang/go#44776. Change-Id: I1bc3df2800a1765296c5164aa8bece495d8f9221 Reviewed-on: https://go-review.googlesource.com/c/mod/+/300149 Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com>
cmd/go: validating version format in mod edit Version strings set by -retract and -exclude are not canonicalized by go mod commands. This change adds validation to go mod edit to prevent invalid version strings from being added to the go.mod file. For golang/go#43280 Change-Id: I3708b7a09111a56effac1fe1165122772e3f2d75 Reviewed-on: https://go-review.googlesource.com/c/mod/+/279394 Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jay Conrod <jayconrod@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> Trust: Michael Matloob <matloob@golang.org>
semver: deprecate semver.Max There are a number of calls to semver.Max in the wild, so let's not delete it yet. For golang/go#32700 Change-Id: I515b05f174195d1b82a931b92e21b83c370ef7c7 Reviewed-on: https://go-review.googlesource.com/c/mod/+/269357 Trust: Jay Conrod <jayconrod@google.com> Run-TryBot: Jay Conrod <jayconrod@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
modfile: scan ASCII brackets and commas as separate tokens
The characters '( ) [ ] { } ,' are now scanned as separate tokens,
even when they are preceded by non-whitespace "identifier"
characters. Previously, '( )' were scanned like this when preceded by
whitespace, but they could be in the middle of an identifier
token. None of these characters are allowed in module paths or
versions. They are allowed within file paths, so file paths containing
them will need to be quoted in the future. Using these characters
should not break ParseLax, since replace directives (the only directive
that allows files paths) are ignored by ParseLax.
Additionally, '(' is only treated as the beginning of a block if it
appears at the end of the line or is immediately followed by ')' at the
end of the line. ')' is treated as the end of a block if it
appears within a block at the beginning of a line.
Fixes golang/go#38167
Updates golang/go#38144
Updates golang/go#24031
Change-Id: I5a7fb522163802c3723d289cf0fbc5856ca075ec
Reviewed-on: https://go-review.googlesource.com/c/mod/+/226639
Reviewed-by: Bryan C. Mills <bcmills@google.com>
sumdb/note: remove draft comment Change-Id: Ie46caf623e8244a5b53ad5a51d1f3a8801d1711d Reviewed-on: https://go-review.googlesource.com/c/mod/+/213120 Reviewed-by: Jay Conrod <jayconrod@google.com>
gosumcheck: basic go.sum checker Copied from golang.org/x/exp/sumdb/gosumcheck. For golang/go#31761. Change-Id: Ia2cf81372b8e2da9b879f3d737de014eb30ea34b Reviewed-on: https://go-review.googlesource.com/c/mod/+/176639 Run-TryBot: Russ Cox <rsc@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>