8000 Do not strip hash from redirection endpoint by jonkoops · Pull Request #219 · keycloak/keycloak-js · GitHub
[go: up one dir, main page]
Skip to content

Do not strip hash from redirection endpoint #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonkoops merged 1 commit into from
Nov 19, 2025
Merged

Do not strip hash from redirection endpoint #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions lib/keycloak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,9 +1220,7 @@ export default class Keycloak {

const params = new URLSearchParams([
['client_id', /** @type {string} */ (this.clientId)],
// The endpoint URI MUST NOT include a fragment component.
// https://datatracker.ietf.org/doc/html/rfc6749#section-3.1.2
['redirect_uri', stripHash(redirectUri)],
['redirect_uri', redirectUri],
['state', state],
['response_mode', this.responseMode],
['response_type', this.responseType],
Expand Down Expand Up @@ -2067,7 +2065,7 @@ async function fetchAccessToken (url, code, clientId, redirectUri, pkceCodeVerif
['code', code],
['grant_type', 'authorization_code'],
['client_id', clientId],
['redirect_uri', stripHash(redirectUri)]
['redirect_uri', redirectUri]
])

if (pkceCodeVerifier) {
Expand Down Expand Up @@ -2155,16 +2153,6 @@ function stripTrailingSlash (url) {
return url.endsWith('/') ? url.slice(0, -1) : url
}

/**
* @param {string} url
* @returns {string}
*/
function stripHash (url) {
const parsedUrl = new URL(url)
parsedUrl.hash = ''
return parsedUrl.toString()
}

/**
* @typedef {Object} NetworkErrorOptionsProperties
* @property {Response} response
Expand Down
28 changes: 28 additions & 0 deletions test/tests/preserves-fragment.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { expect } from '@playwright/test'
import { createTestBed, test } from '../support/testbed.ts'

test('preserves URL fragment after login and logout', async ({ page, appUrl, authServerUrl }) => {
const { executor } = await createTestBed(page, { appUrl, authServerUrl })
const initOptions = executor.defaultInitOptions()
const fragment = '#section=preserved'
const appUrlWithFragment = new URL(appUrl)

appUrlWithFragment.hash = fragment

// Navigate to the application URL with a fragment.
await page.goto(appUrlWithFragment.toString())

// Initialize the adapter and perform login.
await executor.initializeAdapter(initOptions)
await executor.login()
await executor.submitLoginForm()

// After login and adapter initialization, the URL fragment should be preserved.
await executor.initializeAdapter(initOptions)
expect(new URL(await page.url()).hash).toBe(fragment)

// After logout, the URL fragment should still be preserved.
await executor.logout()
await executor.initializeAdapter(initOptions)
expect(new URL(await page.url()).hash).toBe(fragment)
})
0