Repository navigation
Fix admin event paths when request realm casing differs - #55226
Draft
Aschenbath wants to merge 1 commit into
Draft
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
Use the realm matched in the request to derive resource paths for both Admin API versions. Closes keycloak#55222 Signed-off-by: Nash Aschenbath <wwh86696@163.com>
Open
1 task
Member
|
Putting this one on hold. Let's first agree on the solution in the parent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the realm name matched in the request so admin-event resource paths stay relative to the realm when a case-insensitive database accepts different casing. Shared extraction preserves the casing of decoded resource names and IDs in both API versions and keeps unmatched paths intact.
The regressions invoke the builders in real server sessions with the resolved realm model, so they also run on case-sensitive databases. They cover both URI overloads, decoded paths and trailing slashes; the admin-event documentation now describes the path semantics.
Closes #55222
Validation on Windows with JDK 17, the distribution server and H2 (
dev-mem):AdminEventTestpassed 15 tests andAdminEventV2Testpassed 7, with no failures or skips. Before the fix, both mixed-case regressions failed while their same-case controls passed.mvnw.cmd -Pspotless spotless:applyandmvnw.cmd -Pspotless spotless:checkpassed.AI assistance: Codex generated the implementation, regression tests and documentation.