Repository navigation
Wait for the row in the Admin UI E2E clickTableRowItem helper - #55085
Merged
Merged
Conversation
Closes keycloak#55084 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the row-click helper update.
No open issues 🎉
What changed in this PR
Updates the shared Admin UI E2E row-click helper to wait for asynchronously rendered rows, addressing the flaky realm-navigation failure in #55084.
Changes:
- Replaces the rapid retry loop with a Playwright visibility wait using the existing 15-second timeout.
- Prefers an exact case-insensitive match, falling back to the first partial match.
- Uses Playwright’s timeout error when no matching row appears.
| File | Description |
|---|---|
js/apps/admin-ui/test/utils/table.ts |
Removes the retry helper and waits for a matching link before selecting and clicking it. |
Review effort: Balanced
ahus1
marked this pull request as ready for review
November 12, 2026 10:15
ahus1
enabled auto-merge (squash)
November 12, 2026 10:15
edewit
approved these changes
Nov 12, 2026
ahus1
disabled auto-merge
November 12, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55084
Decisions and assumptions:
TABLE_LOAD_TIMEOUT_MS, rather than adding sleeps between attempts.