Repository navigation
Replace a credential only if unchanged when re-hashing a password - #55053
Merged
Merged
Conversation
Add updateStoredCredential(oldCred, newCred) that replaces a stored credential only if it still has the content of the old version, using a pessimistic lock in the JPA stores. Use it in the deferred password re-hash, so that it no longer overwrites a credential that changed after it was validated. Closes keycloak#55028 (cherry picked from commit e4bcd40) Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ahus1
force-pushed
the
is-55028-backport-26.6
branch
from
November 11, 2026 18:12
3ba514f to
2359f6b
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.KcSamlBrokerArtifactBindingTest#testLoginWithSignatureAtAssertionLevelErrorInvalidSignature |
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.broker.KcSamlBrokerArtifactBindingTest#testLoginWithSignatureAtAssertionLevelErrorInvalidSignature |
ahus1
marked this pull request as ready for review
November 12, 2026 09:58
ahus1
enabled auto-merge (squash)
November 12, 2026 09:58
2 tasks done
pedroigor
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add updateStoredCredential(oldCred, newCred) that replaces a stored credential only if it still has the content of the old version, using a pessimistic lock in the JPA stores. Use it in the deferred password re-hash, so that it no longer overwrites a credential that changed after it was validated.
Closes #55028
(cherry picked from commit e4bcd40)