Repository navigation
Correcting SCIM NPE - #55051
Merged
Merged
Correcting SCIM NPE#55051
Conversation
hypery2k
force-pushed
the
bugfix/scim-null-annotations
branch
from
November 11, 2026 15:43
b39858e to
20ce1b1
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The change incorrectly claims to resolve #53260 while single-valued predicates still use EXISTS, requiring either a corrected issue reference or the corresponding fix and regression test.
1 open issue
What changed in this PR
This PR fixes a null-pointer exception in SCIM custom-attribute resolution when user-profile attributes have no annotations.
Changes:
- Skip attributes with missing metadata or annotations without stopping the lookup.
- Add a regression test for filtering a custom attribute after an unannotated attribute.
- Change generated OpenAPI validation descriptions from English to German fragments.
| File | Description |
|---|---|
scim/tests/base/src/test/java/org/keycloak/tests/scim/tck/FilterTest.java |
Adds regression coverage for unannotated user-profile attributes. |
scim/model/src/main/java/org/keycloak/scim/model/user/UserExtensionModelSchema.java |
Handles missing annotations and continues attribute lookup. |
js/libs/keycloak-admin-client/openapi.json |
Introduces locale-only documentation changes unrelated to the SCIM fix. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The claimed #53260 resolution leaves inconsistent null handling between negated equality and inequality, so it needs a predicate fix with regression coverage or a corrected issue reference.
2 open issues
Review effort: Balanced
hypery2k
force-pushed
the
bugfix/scim-null-annotations
branch
from
November 11, 2026 17:48
20ce1b1 to
f10f1a3
Compare
resolves keycloak#55058 Signed-off-by: Martin Reinhardt <martin@m13t.de>
hypery2k
force-pushed
the
bugfix/scim-null-annotations
branch
from
November 11, 2026 18:12
f10f1a3 to
4bd03c8
Compare
pedroigor
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #55058