Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce at least one bearer subject confirmation method and also fail for unsupported methods #55013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Enforce at least one bearer subject confirmation method and also fail for unsupported methods #55013
Changes from all commits
0fa792dFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads as if an assertion carrying both a
bearerand a holder-of-key confirmation is rejected. It is accepted: non-bearer confirmations are ignored as long as a valid bearer one is present, which is whattestBearerAndHolderOfKeySubjectConfirmationIsAcceptedasserts.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this bullet lands between the
NotOnOrAfterandRecipientbullets, splitting the three "SubjectConfirmationDatamust carry ..." items. It would read better directly after the first bullet (the one about the BearerSubjectConfirmation) or at the end of the list.Uh oh!
There was an error while loading. Please reload this page.