Repository navigation
[26.6] Enforce the essential acr level when the flow finishes without a step-up - #54346
Open
michalvavrik wants to merge 4 commits into
Open
michalvavrik wants to merge 4 commits into
michalvavrik wants to merge 4 commits into
Conversation
…thout a step-up closes: keycloak#53157 backports: keycloak#53587 Signed-off-by: Michal Vavřík <dev@michalvavrik.net>
Member
Author
|
I think the JS failure is just flaky and unrelated. |
mabartos
previously approved these changes
Oct 27, 2026
Member
There was a problem hiding this comment.
@michalvavrik LGTM, even the TX rollback for the exception. Thanks!
However, it seems the JS job is quite unstable for 26.6
Member
Author
yeah, I thought it would be better if someone who can (like you) triggered re-running only the failed job. rebasing or new commit is bit lottery and more work for PR CI (resources) |
Signed-off-by: Ricardo Martin <rmartinc@redhat.com>
rmartinc
previously approved these changes
Nov 12, 2026
Contributor
There was a problem hiding this comment.
Thanks @michalvavrik and @mabartos! I have resolved the conflict in the notes and activated auto-merge.
rmartinc
enabled auto-merge (squash)
November 12, 2026 15:15
rmartinc
disabled auto-merge
November 12, 2026 16:19
Signed-off-by: Ricardo Martin <rmartinc@redhat.com>
rmartinc
enabled auto-merge (squash)
November 12, 2026 16:22
Contributor
|
Fixing ag A61C ain the conflict. |
rmartinc
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
services/src/main/java/org/keycloak/authentication/AuthenticationProcessor.javaa rollback specific for this PR in order to avoid keeping changes