Repository navigation
Conversation
ahus1
reviewed
Nov 9, 2026
Member
There was a problem hiding this comment.
Thank you for this PR. There might have been a slight misunderstanding when setting up the issue:
This states to remove the deprecated stacks.
Completely remove the deprecated cache-stack CLI options from Keycloak 27.x, leaving only jdbc-ping as the available built-in stack options
What I probably had in mind: "Completely remove the cache-stack CLI option", which would mean no longer specifying --cache-stack on the CLI. The "escape hatch" for people who want to use their own stack would then be to put it into the caching XML file.
Please remove those extra parts, or we can discuss it in more details in our team planning meeting.
Removing those extra parts would then need some touch-up on the migration guide.
ruchikajha95
force-pushed
the
iss-54598/Remove-deprecated-cache-stack-CLI-options
branch
from
November 10, 2026 16:44
44dc441 to
2b80b1f
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
All seven changed help snapshots are truncated after Cache even though the CLI still prints later sections, causing full-output approval tests to fail.
No open issues 🎉
What changed in this PR
Removes the --cache-stack option from Keycloak as a follow-up to #54598. Default clustering continues to use jdbc-ping, while custom stacks are configured through cache XML.
Changes:
- Removes stack option definitions, runtime mapping, validation and compatibility metadata.
- Updates affected tests, CLI help snapshots and operator configuration handling.
- Documents the removal and the migration path for custom stacks.
| File | Description |
|---|---|
| testsuite/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/arquillian/containers/AbstractQuarkusDeployableContainer.java | Stops passing the stack CLI argument. |
| quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testUpdateCompatibilityMetadataHelpAll.approved.txt | Updates metadata full-help expectations. |
| quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testUpdateCompatibilityMetadataHelp.approved.txt | Updates metadata help expectations. |
| quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testUpdateCompatibilityCheckHelpAll.approved.txt | Updates compatibility-check full-help expectations. |
| quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testUpdateCompatibilityCheckHelp.approved.txt | Updates compatibility-check help expectations. |
| quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartOptimizedHelpAll.approved.txt | Updates optimized-start full-help expectations. |
| quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartOptimizedHelp.approved.txt | Updates optimized-start help expectations. |
| quarkus/tests/integration/src/test/resources/org/keycloak/it/cli/dist/approvals/cli/help/HelpCommandDistTest.testStartHelp.approved.txt | Updates start help expectations. |
| quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/ClusterConfigDistTest.java | Removes obsolete stack validation tests. |
| quarkus/runtime/src/test/java/org/keycloak/quarkus/runtime/configuration/ConfigurationTest.java | Removes the stack mapping assertion. |
| quarkus/runtime/src/test/java/org/keycloak/quarkus/runtime/cli/UpdateCompatibilityPicocliTest.java | Removes stack compatibility checks. |
| quarkus/runtime/src/test/java/org/keycloak/quarkus/runtime/cli/PicocliTest.java | Uses default discovery in pool-size validation. |
| quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/configuration/mappers/DatabasePropertyMappers.java | Simplifies the JDBC discovery check. |
| quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/configuration/mappers/CachingPropertyMappers.java | Removes stack mapping and revises TLS help wording. |
| quarkus/config-api/src/main/java/org/keycloak/config/CachingOptions.java | Removes the stack enum and option definition. |
| operator/src/test/java/org/keycloak/operator/testsuite/unit/PodTemplateTest.java | Uses cache configuration files for environment precedence testing. |
| operator/src/main/java/org/keycloak/operator/controllers/KeycloakRealmImportJobDependentResource.java | Removes stack-specific environment filtering. |
| model/infinispan/src/main/java/org/keycloak/spi/infinispan/impl/embedded/JGroupsConfigurator.java | Removes stack overrides and unsupported-stack errors. |
| model/infinispan/src/main/java/org/keycloak/spi/infinispan/impl/embedded/DefaultCacheEmbeddedConfigProviderFactory.java | Removes the stack configuration constant. |
| model/infinispan/src/main/java/org/keycloak/infinispan/compatibility/CachingEmbeddedMetadataProvider.java | Stops recording the stack configuration key. |
| docs/guides/server/update-compatibility.adoc | Removes the stack option from recreate-update triggers. |
| docs/documentation/upgrading/topics/changes/changes-27_0_0.adoc | Documents option removal and custom-stack migration. |
Review effort: Balanced
ruchikajha95
force-pushed
the
iss-54598/Remove-deprecated-cache-stack-CLI-options
branch
from
November 11, 2026 14:48
07d20fc to
a199872
Compare
Closes keycloak#54598 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#54598 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#54598 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
Closes keycloak#54598 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
ruchikajha95
force-pushed
the
iss-54598/Remove-deprecated-cache-stack-CLI-options
branch
from
November 11, 2026 14:51
5749a8a to
ef220e9
Compare
…d after cleanup Closes keycloak#54598 Signed-off-by: Ruchika <ruchika.jha1@ibm.com>
ahus1
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54598