Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unguarded expression-index changeset fails on supported databases such as SQL Server, blocking schema migrations for fresh installations and upgrades.
1 open issue
What changed in this PR
This PR addresses #37454 by adding an index intended to speed up case-insensitive user-attribute searches in Keycloak’s JPA storage.
Changes:
- Adds a composite index on
USER_ATTRIBUTEusingNAMEandLOWER(VALUE). - Registers the 27.0.0 migration in the master changelog.
- Documents the new index in the upgrade guide.
| File | Description |
|---|---|
model/jpa/src/main/resources/META-INF/jpa-changelog-master.xml |
Includes the 27.0.0 changelog. |
model/jpa/src/main/resources/META-INF/jpa-changelog-27.0.0.xml |
Defines the lowercase attribute-value index. |
docs/documentation/upgrading/topics/changes/changes-27_0_0.adoc |
Describes the index’s intended search-performance benefit. |
Review effort: Balanced
resah
force-pushed
the
feat/search-index-user-attr
branch
from
November 3, 2026 12:47
2158113 to
f67d509
Compare
vramik
approved these changes
Nov 5, 2026
pedroigor
approved these changes
Nov 6, 2026
Contributor
|
@resah, would you mind rebasing and solving conflicts? |
pedroigor
previously approved these changes
Nov 11, 2026
Closes keycloak#37454 Signed-off-by: Theresa Henze <theresa.henze@bare.id>
resah
force-pushed
the
feat/search-index-user-attr
branch
from
November 12, 2026 09:35
f67d509 to
5790d40
Compare
Contributor
Author
@pedroigor Done |
Contributor
|
@resah, sorry, asking you again, can you rebase it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37454