Repository navigation
release prebuilt macOS and Linux binaries and point Homebrew at them - #38
Merged
Conversation
…omebrew formula at them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install jrnxf/tap/thokrwill download a prebuilt binary instead of compiling with cargo. Av*tag now builds thokr for macOS (Apple silicon, Intel) and Linux (static musl, x86-64 and ARM). It publishes the release with.tar.gz+.sha256archives, publishes the crate, and pointsFormula/thokr.rbin jrnxf/homebrew-tap at the new binaries.Review (about 10 min):
.github/workflows/release.yml, modeled on okfs's, with the first-release formula rewrite from jrnxf/fsrx PR 14. This PR's own run of the workflow builds all four binaries without publishing.v0.6.1and nothing else is needed.Formula/thokr.rbtobin.install "thokr", keeping cargo in ahead doblock for--HEAD. Later releases skip the rewrite and only move the urls.deploy.ymlis gone. Its crate and tap jobs moved intorelease.yml, because a release made with the workflow's token never firesrelease: published.CRATES_TOKENandTAP_DEPLOY_KEYare already set, and the tap'sthokr-tap-bumpkey is read-write. Nothing to add.Checked locally against a scratch copy of the tap, using this PR's CI archives (v0.6.0, from before the bump):
bump-formula.shwrote all four sha256s, matching the published.sha256files. A second run changed nothing.brew style(with the tap's Desc exception) andbrew audit --strictpass.brew installandbrew testpass. The binary install has no build dependencies, and only--HEADpulls in rust.--HEADbuild, and the push to the tap. The v0.6.1 release run covers those.