Repository navigation
Audit dependencies on every change and on a weekly schedule - #675
Open
irfan-dahir wants to merge 1 commit into
Open
irfan-dahir wants to merge 1 commit into
irfan-dahir wants to merge 1 commit into
Conversation
The repository deliberately does not commit composer.lock, so a fresh install already resolves the newest patch release inside jikan's constraints; a pinned-version gate is not possible and would not have helped. What this adds is a check for the case that resolve cannot fix: an advisory with no release inside the constraints, which a weekly run finds even when nothing in the repository changed. Production advisories fail the build because require-dev never reaches a consumer; dev-tool advisories are reported without blocking, so an unavailable patch for phpunit or grumphp cannot hold up unrelated work.
Collaborator
Author
|
End-to-end check of the gate itself (ran locally today, 2026-11-12), since a workflow that only ever passes proves nothing: Clean tree — fresh clone of this branch, Vulnerable tree — same clone, So the blocking step fails the job for a runtime advisory, the way it is supposed to, and the advisory is not swallowed by the non-blocking dev step. Nothing else changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/security.yaml:composer auditon push to master, on every PR, and weekly on a cron.Why this shape
The repository deliberately does not commit
composer.lock(it is in.gitignore— this is a library). That has a consequence worth stating, because it surprised me:composer auditreported locally (symfony/http-client 8.1.8, symfony/config 8.1.5, symfony/filesystem 8.1.6, symfony/yaml 8.1.8, phpunit 13.4.2) came from a stale localvendor/, not from anything CI would install. There is nothing to patch in the repository — bumping constraints to^8.1.11would over-constrain a library for no gain.Hence the split:
composer audit --no-devcomposer auditcontinue-on-error)The weekly cron is the part that would have mattered on 2026-11-11: those advisories appeared long after the last dependency change, and Dependabot — although configured, with alerts and security fixes enabled — has never opened a PR here and reports 0 open alerts, so GitHub is not surfacing them.
Notes
composer audit. Add it to the required checks in branch protection if you want it to gate merges; right now it reports alongsideQuality/Tests.CHANGELOG.mdentry: CI-only, no consumer-visible change.