Repository navigation
getHelpfulCount() returns the review's total reactions - #662
Merged
Merged
Conversation
MyAnimeList's 2022 review redesign replaced "helpful" votes with reactions. The anime getHelpfulCount() was a hard-coded 0 and the manga one failed looking for the removed vote markup. Both now return the reactions total MyAnimeList reports (owner decision: total of all reactions), documented as such. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MyAnimeList's 2022 review redesign replaced "helpful" votes with seven reactions (Nice, Love it, Funny, Confusing, Informative, Well-written, Creative). Neither
getHelpfulCount()worked:return 0; //@todo replace with reactions array, with the old parsing code below it never running.Both now return the total reactions MyAnimeList reports for the review (
getReactions()->getOverall()). The docblock says what it counts: all reactions, including Funny and Confusing.getReactions()gives the breakdown. This was the owner's decision; deprecating it was the alternative.Test:
ReviewScoresTestchecks every recorded anime and manga review. The helpful count equals MyAnimeList's total, the total equals the sum of the seven reactions, and it isn't always 0.Changelog: under Changed, since the value goes from always-
0to a real count.🤖 Generated with Claude Code