Repository navigation
RC sweep: user reviews pagination, dead imports, stale todos - #659
Merged
Merged
Conversation
- UserReviewsParser::hasNextPage() was hard-coded to true and
getLastVisiblePage() to 1. MyAnimeList shows 10 per page and links only the
next one ("More Reviews", ?p=N, checked live); both now follow that link.
- Removed 8 `use` lines naming classes that do not exist (never referenced).
- Removed two @todo comments for pagination that was implemented earlier.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The PR's mutation run flagged a no-op max(1, ...) and casts; the next page is now the lowest linked page after the current one. Tests cover a URL with no ?p= and links to the current page and several later ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied
2E86
from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by an RC-readiness sweep of the repository.
UserReviewsParser::hasNextPage()was hard-coded totrueandgetLastVisiblePage()to1, both marked "TODO: Add implementation".?p=N, with no page count.UserReviewsPaginationTestcovers one page, a next-page link, and a link back to an earlier page. There's a changelog entry under Fixed.uselines naming classes that don't exist (LicensorMeta,StudioMeta, and others). None was referenced, so nothing changes at runtime.@todos: removed two "pagination" comments for work that was done in Test suite phase 2: clock, variant corpus, and the parser bugs it found #643.No
srcbehaviour changes apart from the pagination fix. The security advisory from the sweep (symfony/expression-language, pulled in by GrumPHP) is a dev-only dependency.composer.lockisn't tracked, so CI and fresh installs already get the patched v8.1.9.🤖 Generated with Claude Code