Repository navigation
<
8000
div class="js-pull-header-details" data-pull-is-open="false" hidden="">
Mask secret config values in the startup log - #452
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RelaySecretandWebhookUrlbecome aSecrettype whoseMarshalTextreturns***, so theconfig loadedlog line prints a mask instead of the value. Both are still loaded as-is and passed throughstring(...)where used.After deploy, please consider reissuing the relay secret (
GDXSV_RELAY_SECRET) and the Discord webhook URL (GDXSV_WEBHOOK_URL), since older log lines contain the current values.Verification (windows-mini, Go 1.27.4):
loadConfigwith dummy values and checked the JSON and console encoders. Againstmaster, both dummy values showed up in both outputs (FAIL). With this change it PASSES, andconfstill holds the real values. I removed the test before committing.go vet ./...andgo test ./...pass.🤖 Generated with Claude Code