8000 Mask secret config values in the startup log by inada-s-ai[bot] · Pull Request #452 · inada-s/gdxsv · GitHub
[go: up one dir, main page]

Skip to content
< 8000 div class="js-pull-header-details" data-pull-is-open="false" hidden="">

Mask secret config values in the startup log - #452

Merged
inada-s merged 1 commit into
masterfrom
ai/config-secret-mask
Nov 20, 2026
Merged

inada-s merged 1 commit into
masterfrom
ai/config-secret-mask

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 19, 2026
Copy link
Copy Markdown
Contributor

RelaySecret and WebhookUrl become a Secret type whose MarshalText returns ***, so the config loaded log line prints a mask instead of the value. Both are still loaded as-is and passed through string(...) where used.

After deploy, please consider reissuing the relay secret (GDXSV_RELAY_SECRET) and the Discord webhook URL (GDXSV_WEBHOOK_URL), since older log lines contain the current values.

Verification (windows-mini, Go 1.27.4):

  • A throwaway test called loadConfig with dummy values and checked the JSON and console encoders. Against master, both dummy values showed up in both outputs (FAIL). With this change it PASSES, and conf still holds the real values. I removed the test before committing.
  • Full go vet ./... and go test ./... pass.
  • Not run: deploy, live relay registration, webhook post.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s
inada-s merged commit a85aa52 into master Nov 20, 2026
2 checks passed
@inada-s
inada-s deleted the ai/config-secret-mask branch November 20, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0