Repository navigation
fix(test): use relative future dates in ICS test to avoid time bombs - #156
Merged
Merged
Conversation
The 'ics carries the huddl identity and timing' test hardcoded date: ~D[2026-05-01], start_time: ~T[14:00:00] — which on May 1 2026 became a date in the past after 14:00 UTC, causing the huddl create action's FutureDateValidation to reject the generator and fail the test. Replace both hardcoded dates in this file with Date.add(Date.utc_today(), N), and compute the expected DTSTART/DTEND substrings from the same date so the assertions stay accurate. Closes #152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `ics_test.exs` "event_for/1 carries the huddl identity and timing" test hardcoded `date: ~D[2026-05-01], start_time: ~T[14:00:00]`. On May 1 2026 (today), any test run after 14:00 UTC produced a date+time in the past, which the huddl create action's `FutureDateValidation` correctly rejects — failing the test with what looked like a "flaky generator" failure.
It was never the generator. It was a literal expired date.
Fix
Why it shows up everywhere
Every PR opened today has CI failing on this test, even though their changes are unrelated. Merging this first will let the other open PRs (#146, #147, #151, #153, #155) go green.
Closes #152
Test plan