Repository navigation
test(harness): reduce setup duplication in test suite - #110
Merged
Merged
Conversation
- generate_group_with_members/2 collapses owner→group→members setup - Huddlz.Test.MoxHelpers centralizes Places/Geocoding stub shapes - drop Process.sleep(10) in image tests; inserted_at is microsecond-precise
- password reset send is synchronous (Swoosh Mailer.deliver!) - huddl create is synchronous (no Task/Oban, Ash async disabled in test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_group_with_members/2to collapse the owner→group→members triple into one call (biggest win:group_live_permissions_test.exs, -59 lines).Huddlz.Test.MoxHelpers(stub_places_autocomplete,stub_place_details,stub_geocode, plus error variants) with canonical Places fixtures, adopted in 6 test files.Process.sleepcalls from the test suite:inserted_atis microsecond-precise and rapid inserts are reliably ≥385µs apart.Mailer.deliver!, no Oban/Task, Ash async disabled in test).Net: -168 LOC across 18 files. All 616 tests pass; 5 consecutive seeded runs clean.
Test plan