8000 ocaml-5.5.2: GithubRepo provenance so the vuln scan covers it (0 rebuilds) by bryan-minimal · Pull Request #1461 · gominimal/pkgs · GitHub
[go: up one dir, main page]

Skip to content

ocaml-5.5.2: GithubRepo provenance so the vuln scan covers it (0 rebuilds) - #1461

Open
bryan-minimal wants to merge 1 commit into
mainfrom
ocaml-seed-provenance
Open

bryan-minimal wants to merge 1 commit into
mainfrom
ocaml-seed-provenance

Conversation

@bryan-minimal
@bryan-minimal bryan-minimal commented Nov 12, 2026 •
Copy link
Copy Markdown
Member

pkgmgr's nightly coverage gate (vuln-db coverage-health) failed at 00:02 because two packages that #1242 added can no longer be checked for advisories: ghc-9.6.7 and ocaml-5.5.2.

ocaml-5.5.2 is the seed compiler that packages/ocaml now builds from. #1242 gave it a 'Website provenance (ocaml.org plus the caml.inria.fr distrib directory). No advisory source can query that shape, so the package went dark. packages/ocaml itself is covered through 'GithubRepo ocaml/ocaml, and this PR gives the seed the same provenance. go-1.24.9 and rustc-1.98.1 are covered the same way (golang/go, rust-lang/rust).

Rebuilds: 0. attrs are not part of the spec hash (mip dump --packages, amd64, against main).

ghc-9.6.7 is handled on the pkgmgr side. ghc and ghc-bootstrap are already in pkgmgr's coverage baseline because no advisory source tracks the GHC compiler. A GithubRepo ghc/ghc provenance would make the gate pass with queries that can only return nothing, so ghc-9.6.7 joins them in the baseline instead.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • OCaml 5.5.2 package source information now identifies the upstream OCaml GitHub repository instead of listing the project website and downloads page. This updates the repository details shown in package metadata; no changes to OCaml’s functionality are included.

@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 12, 2026 17:00
@coderabbitai
coderabbitai Bot commented Nov 12, 2026 •
Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The OCaml 5.5.2 package replaces website-based source provenance with GitHub repository provenance. The metadata names ocaml as the owner and repository.

Changes: OCaml source provenance

Layer / File(s) Summary
Update source provenance
packages/ocaml-5.5.2/build.ncl
The comment and source_provenance metadata now identify the ocaml/ocaml GitHub repository instead of website URLs.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: norrietaylor, mitodrummer

Merge Risk: Minimal · up to 86466

This change lets the vulnerability scan check the OCaml 5.5.2 package for advisories again. It does not change build behavior, and no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: ocaml-5.5.2 switches to GithubRepo provenance so the vulnerability scan covers it. The PR summary and raw summary both confirm this change to packages/ocaml-5.5.2/buil…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: ocaml-5.5.2 switches to GithubRepo provenance so the vulnerability scan covers it. The PR summary and raw summary both confirm this change to packages/ocaml-5.5.2/build.ncl. The title also states the expected outcome of zero rebuilds, which the objectives support because attrs are not part of the spec hash. The title is specific, single-sentence, and not vague.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c8f2093 and 8646644.

Files selected for processing: 1

  • packages/ocaml-5.5.2/build.ncl

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0