8000 fix(minimal): the CLI references say how a box reaches a host port, and say that an own-address box by minimal-foundry[bot] · Pull Request #3709 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): the CLI references say how a box reaches a host port, and say that an own-address box - #3709

Draft
minimal-foundry[bot] wants to merge 1 commit into
mainfrom
agent/3699-the-cli-references-say-how-a-box-reaches-a-host
Draft

minimal-foundry[bot] wants to merge 1 commit into
mainfrom
agent/3699-the-cli-references-say-how-a-box-reaches-a-host

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

Follow-up

Fixes #3699

Task marker
### D3699 — The CLI references say how a box reaches a host port, and say that an own-address box reaches a host exposure
  kind: task
  size: S
  est: 15 code, 40 tests
  executor: agent
  origin: residual
  epic: 1437
  layers:
    - docs:
      - docs/reference/cli-minvmd.md: Remove the sentences that say an own-address box gets a refusal at every port and that #2990 tracks the change. Say that an own-address box reaches an exposure when its egress names host.min.internal or its allow_subnets covers that address (NET-160).
      - docs/reference/cli-min.md: Beside the sentence that host.min.internal resolves, say that the name alone opens no host port. Say that a box reaches the host only at a [host-exposures] port and only when its egress names the host, as NET-156 and NET-160 state. Link the minvmd page.
      - crates/minimal/src/tests.rs: Add a test that reads both pages. It fails when cli-minvmd.md says an own-address box is refused at every port, or when cli-min.md does not name [host-exposures] in the paragraph that names host.min.internal.
      test: cargo test -p minimal cli_reference_says_how_a_box_reaches_the_host
  proof: docs/reference/cli-minvmd.md and docs/reference/cli-min.md tell a reader that an own-address box reaches a host service through a [host-exposures] entry and an egress rule that names host.min.internal.

Proof

docs/reference/cli-minvmd.md now says an own-address box reaches an exposure when its egress.allow_dns_hosts names host.min.internal or its egress.allow_subnets covers that address, and the refusal note and the #2990 link are gone. docs/reference/cli-min.md says, beside host.min.internal, that the name alone opens no host port, that a box reaches the host only at a [host-exposures] port, and that an own-address box also needs an egress rule that names the host. It links the minvmd page.

Notes from the agent: The task covers no spec section (spec.md was empty), so the text follows the task notes and the existing minvmd page. In cli-min.md the sentence 'min session start prints one line saying so' now reads 'When an own-address box gets the deny-all default, min session start prints one line that says so'. Without this change, 'so' points at the new host-port sentences. just lint-prose did not run: vale is not installed on this box.

Tests

line exit tail
cargo test -p minimal cli_reference_says_how_a_box_reaches_the_host 0 running 1 test test tests::cli_reference_says_how_a_box_reaches_the_host ... ok test result: ok. 1 passed; 0 failed; 0 8000 ignored; 0 measured; 1060 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 43 filtered out; finished in 0.00s runni

Verify

min task run agent-verify exited 100, so this PR is a draft.

8) minimal::bin/min tests::invalid_project_file_for_box_spec_says_spec_cannot_show
        PASS [   0.005s] (1203/1228) minimal::bin/min tests::invalid_project_file_prints_toml_error_once
        PASS [   0.005s] (1204/1228) minimal::bin/min tests::invalid_project_file_prints_toml_error_once_for_io
        PASS [   0.005s] (1205/1228) minimal::bin/min tests::loadout_not_found_exits_4
        PASS [   0.005s] (1206/1228) minimal::bin/min tests::local_host_not_found_exits_4
        PASS [   0.005s] (1207/1228) minimal::bin/min tests::machine_mode_answers_write_failures
        PASS [   0.005s] (1208/1228) minimal::bin/min tests::machine_mode_error_line_keeps_an_empty_hint
        PASS [   0.005s] (1209/1228) minimal::bin/min tests::machine_mode_error_object_is_one_stamped_line
        PASS [   0.005s] (1210/1228) minimal::bin/min tests::machine_mode_error_object_on_stderr
        PASS [   0.005s] (1211/1228) minimal::bin/min tests::machine_mode_names_the_grant_refusal_code
        PASS [   0.005s] (1212/1228) minimal::bin/min tests::machine_output_mode_keys_on_the_output_flag
        PASS [   0.005s] (1213/1228) minimal::bin/min tests::misplaced_run_flag_exits_2
        PASS [   0.005s] (1214/1228) minimal::bin/min tests::network_flag_refusal_exits_2
        PASS [   0.005s] (1215/1228) minimal::bin/min tests::project_file_not_found_exits_4
        PASS [   0.005s] (1216/1228) minimal::bin/min tests::prune_off_tty_needs_yes_exits_2
        PASS [   0.004s] (1217/1228) minimal::bin/min tests::resume_and_session_attach_refusals_map_to_exit_codes
        PASS [   0.005s] (1218/1228) minimal::bin/min tests::rm_running_box_refuses_naming_force_with_exit_2
        PASS [   0.004s] (1219/1228) minimal::bin/min tests::row_not_back_exit_codes
        PASS [   0.005s] (1220/1228) minimal::bin/min tests::run_verbs_and_wait_timeout_return_124_with_code_timeout
        PASS [   0.005s] (1221/1228) minimal::bin/min tests::start_entry_refusals_exit_with_their_codes
        PASS [   0.006s] (1222/1228) minimal::bin/min tests::task_file_invalid_exits_3
        PASS [   0.005s] (1223/1228) minimal::bin/min tests::task_network_key_a_task_does_not_apply_exits_3
        PASS [   0.005s] (1224/1228) minimal::bin/min tests::task_not_found_exits_4
        PASS [   0.005s] (1225/1228) minimal::bin/min tests::task_run_is_a_stdout_contract
        PASS [   0.005s] (1226/1228) minimal::bin/min tests::type_refusals_exit_3_and_4
        PASS [   2.053s] (1227/1228) minimal::named_vm named_vm_reaches_autospawn
  stdout ───

    running 1 test
    test exec_run_attach_and_task_run_share_the_commands_trace ... FAILED

    failures:

    failures:
        exec_run_attach_and_task_run_share_the_commands_trace

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5 filtered out; finished in 13.12s

  stderr ───

    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
error: test run failed

An own-address box reaches a [host-exposures] port when its egress names
host.min.internal or covers its address. Drop the stale refusal note in
cli-minvmd.md, explain the rule beside host.min.internal in cli-min.md,
and pin both pages with a test.
@coderabbitai
coderabbitai Bot commented Nov 20, 2026
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad7e4225-3a2e-40f7-b60b-d286c070f68e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The CLI references say an own-address box cannot reach a host exposure, and do not say how a box reaches the host

0 participants

0