Repository navigation
fix(minimal): the CLI references say how a box reaches a host port, and say that an own-address box - #3709
Draft
minimal-foundry[bot] wants to merge 1 commit into
Conversation
An own-address box reaches a [host-exposures] port when its egress names host.min.internal or covers its address. Drop the stale refusal note in cli-minvmd.md, explain the rule beside host.min.internal in cli-min.md, and pin both pages with a test.
Contributor
|
Important Review skippedBot user detected. Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up
Fixes #3699
docs/reference/cli-minvmd.mddocs/reference/cli-min.mdcrates/minimal/src/tests.rsTask marker
Proof
docs/reference/cli-minvmd.md now says an own-address box reaches an exposure when its egress.allow_dns_hosts names host.min.internal or its egress.allow_subnets covers that address, and the refusal note and the #2990 link are gone. docs/reference/cli-min.md says, beside host.min.internal, that the name alone opens no host port, that a box reaches the host only at a [host-exposures] port, and that an own-address box also needs an egress rule that names the host. It links the minvmd page.
Notes from the agent: The task covers no spec section (spec.md was empty), so the text follows the task notes and the existing minvmd page. In cli-min.md the sentence 'min session start prints one line saying so' now reads 'When an own-address box gets the deny-all default, min session start prints one line that says so'. Without this change, 'so' points at the new host-port sentences. just lint-prose did not run: vale is not installed on this box.
Tests
cargo test -p minimal cli_reference_says_how_a_box_reaches_the_hostVerify
min task run agent-verifyexited 100, so this PR is a draft.