8000 fix(mctx): an in-box min patched-pkg of a task builds in the classifier leaf of its box, or on the by minimal-foundry[bot] · Pull Request #3708 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(mctx): an in-box min patched-pkg of a task builds in the classifier leaf of its box, or on the - #3708

Merged
mitodrummer merged 1 commit into
mainfrom
agent/3697-an-in-box-min-patched-pkg-of-a-task-builds-in-th
Nov 21, 2026
Merged

mitodrummer merged 1 commit into
mainfrom
agent/3697-an-in-box-min-patched-pkg-of-a-task-builds-in-th

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

Follow-up

Fixes #3697

Task marker
### D3697 — An in-box min patched-pkg of a task builds in the classifier leaf of its box, or on the network of an own-address box
  kind: task
  size: S
  est: 25 code, 60 tests
  executor: agent
  origin: residual
  epic: 1437
  layers:
    - mctx:
      - crates/mctx/src/env.rs: run_patched_pkg gives op::PatchedBuild the classifier leaf of its context, or the box network when the context has no leaf, as the session channel in minimald does. A small function makes that choice. A context made for no box gives None for both.
      - crates/mctx/src/lib.rs: Add a test beside task_env_carries_the_box_classifier_leaf. A context with a leaf gives the patched build that leaf, a context with a box network gives that network, and a plain context gives neither.
      test: cargo test -p mctx patched_build_takes_the_leaf_or_the_network_of_its_box
  proof: In a deny-all task box, a min patched-pkg build that needs a download is refused under the box's egress rules, as a min install build in the same box is.

Proof

An in-box min patched-pkg build now runs in the classifier leaf of its box, or on the box network when the box has no leaf. So in a deny-all task box, a patched-pkg build that needs a download gets the box's egress rules, as a min install build in the same box does. The unit test shows the choice: leaf, network, or neither for a context made for no box.

Notes from the agent: The choice is in env::patched_build_egress. A leaf wins over a network, which matches crates/minimald/src/env.rs. No end-to-end run in a deny-all box was made on this machine. The unit test proves the wiring, not a refused download. cargo clippy -p mctx --all-targets is clean.

Tests

line exit tail
cargo test -p mctx patched_build_takes_the_leaf_or_the_network_of_its_box 0 running 1 test test tests::patched_build_takes_the_leaf_or_the_network_of_its_box ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 82 filtered out; finished in 0.00s warning: unknown fields in task runtime-implement-test-0: network help: do you need to update to a newer version

Verify

min task run agent-verify passed ([tasks.verify]).

run_patched_pkg now gives op::PatchedBuild the classifier leaf of its
context, or the box network when the context has no leaf, as the
session channel in minimald does. A context made for no box gives
neither, so the build stays the caller's own traffic.
@coderabbitai
coderabbitai Bot commented Nov 20, 2026
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9f715f8b-f8c3-4fec-b6e4-051425280a18

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 9756aaaca3eb.

Nothing to do.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

This change conforms to the networking design. Section 7.1 line 267 says that a hash not in the creator's table builds under the requesting box's own rules. A patched spec is such a hash. run_patched_pkg now gives the build the box's leaf, or the box's network when the box has no leaf. Before, the build ran as the daemon's own traffic. The choice is the same as the minimald session channel. Nobody ran the deny-all runtime proof, and no e2e leg runs min patched-pkg. Note this for the epic's acceptance walk.

Ruled at 9756aaa against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 20, 2026
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit 0ca09fe Nov 21, 2026
40 checks passed
@mitodrummer
mitodrummer deleted the agent/3697-an-in-box-min-patched-pkg-of-a-task-builds-in-th branch November 21, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An in-box min patched-pkg of a task builds outside the egress rules of its box

1 participant

0