Repository navigation
fix(boxes,minimal): the store check admits every upstream host on a host_ip box with no egress - #3707
minimal-foundry[bot] wants to merge 5 commits into
Conversation
store_refusals and check_store_references take the box's network mode and skip the host check when egress_admits_every_name holds, as the GitHub check does (BEP-036, BEP-008).
min box start and min box spec now admit every registered upstream on a host_ip box with no egress section, as the GitHub check does. BEP-036 states that case.
|
Important Review skippedBot user detected. Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.
|
Spec lint
Advisory. None of this blocks the merge; the review decides. Advisory, and never a merge gate. Linter: |
A host_ip box with no egress section now admits every store upstream, so the entry preview test checks the store refusal on own_ip.
…check-admits-every-upstream-host-on-a
|
Round 1 of 10 on a failed check suite, pushed as
Verify Converted to a draft: verify exited 100. On a host_ip box with no egress section, min starts the box with a store secret whose rule registers api.example.com. An own_ip box with no egress section is still refused, and min box spec gives the same refusal as the start. Notes from the agent: The CI log excerpt did not name the failing test. A full local run of the minimal lib tests found box_spec_entry_preview_refuses_like_start. Its store case ran on the default network (host_ip) with no egress and expected a refusal, which this task removes on purpose. The case now passes --network own_ip, so it still checks the store refusal on the mode that keeps it. This round changed only that test case and its comment in crates/minimal/src/cmd/boxes/create.rs. Other failures in the full local run are environmental: many tests::* end-to-end tests and autospawn the_liveness_probe_does_not_wait_on_a_full_accept_queue fail under parallel load here, and box_id_is_a_csprng_uuidv7_per_creation passes when run alone. The boxes doctests did not run here because this box has no rustdoc. The full cargo test -p minimal run passed the 30-minute limit, so I did not get a complete result from it. |
Follow-up
Fixes #3692
crates/boxes/src/core/bep.rscrates/minimal/src/cmd/boxes/create.rscrates/minimal/src/cmd/box_spec.rsdocs/specs/24-spec-box-egress-proxy/24-spec-box-egress-proxy.mdTask marker
Proof
On a host_ip box with no egress section, min box start and min box spec now accept a store secret whose rule registers api.example.com. An own_ip box with no egress section is still refused with exit 3 and names api.example.com as the missing host.
Notes from the agent: store_refusals and check_store_references take a NetworkMode after secrets. The host check is skipped when egress_admits_every_name holds. The sign-in item refusal (BEP-034) still applies in every mode. Existing tests that pass an egress section or None now pass NetworkMode::OwnIp, so they keep their old meaning. The BEP-036 property in the spec now excludes the host_ip box with no egress section, and a new WHERE clause states that case. Also ran cargo test -p minimal store_ (16 passed) and cargo clippy -p minimal --all-targets (no warnings). Did not run just ci or the Vale prose lint.
Tests
cargo test -p boxes store_reference_with_rule_and_no_egresscargo test -p minimal store_grant_on_host_ip_box_with_no_egress_is_acceptedVerify
min task run agent-verifyexited 100, so this PR is a draft.