8000 fix: on a VM lane, the session e2e asserts a listen publication's decision record in the host-held by minimal-foundry[bot] · Pull Request #3704 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix: on a VM lane, the session e2e asserts a listen publication's decision record in the host-held - #3704

Merged
norrietaylor merged 3 commits into
mainfrom
agent/3698-on-a-vm-lane-the-session-e2e-asserts-a-listen-pu
Nov 21, 2026
Merged

norrietaylor merged 3 commits into
mainfrom
agent/3698-on-a-vm-lane-the-session-e2e-asserts-a-listen-pu

Conversation

@minimal-foundry
Copy link
Copy Markdown
Contributor

Follow-up

Fixes #3698

Task marker
### D3698 — On a VM lane, the session e2e asserts a listen publication's decision record in the host-held audit log
  kind: task
  size: S
  est: 0 code, 45 tests
  executor: agent
  origin: residual
  epic: 1437
  layers:
    - e2e:
      - scripts/session-e2e.sh: In listen_published_port_reaches_peer_and_host, replace the VM-lane not_run of the audit leg with an assertion on the VM host daemon's audit/box-admissions.log: a line for the box and the port with source listen. Print the line, and fail when it is absent.
      test: bash scripts/session-e2e.sh listen_published_port_reaches_peer_and_host
  proof: On a KVM or macOS VM lane, listen_published_port_reaches_peer_and_host prints the host-held audit line for the listen's port and is not in the NOT RUN list.

Proof

On a KVM or macOS VM lane, listen_published_port_reaches_peer_and_host now reads $XDG_STATE_HOME/minimal/providers/local-minvmd0/audit/box-admissions.log, prints the 'host audit: {...}' line for box e2e-dyn-listen, port 18112, source listen, and fails when no such line arrives within 5 s. The VM-lane not_run for the audit leg is gone, so the case no longer appears in the NOT RUN list for that reason.

Notes from the agent: The VM leg is unverified here. This box has no KVM and no switch, so the test line skipped the whole case and exited 0. A KVM or macOS VM lane must supply the evidence. The match follows the existing expose leg (eib_vm_admission_line): the box name, the port followed by ',' or '}', and '"source":"listen"'. That is the serde snake_case form of PortReportSource::Listen in the AdmittedPortAudit record (crates/minvmd/src/control.rs). The read polls 20 times at 0.25 s because the host copy is written when the admission happens. The path assumes the default VM, local-minvmd0, the same one this case already uses for its boot log. The native lane's decisions.log leg is unchanged.

Tests

line exit tail
bash scripts/session-e2e.sh listen_published_port_reaches_peer_and_host 0 ::warning::could not fetch the pinned gvproxy switch; native own-IP proofs will skip (stage /workbench/.scratch/gvproxy or install gvproxy-min under $MINIMAL_BIN) fetch-gvproxy: building gvproxy-linux-amd64 v0.9.0 from the pinned source build-gvproxy: downloading https://go.dev/dl/go1.26.10.linux-am

Verify

min task run agent-verify passed ([tasks.verify]).

On a VM lane, listen_published_port_reaches_peer_and_host no longer
counts its audit leg NOT RUN. It reads the VM host daemon's
audit/box-admissions.log for a line with the box, the listen's port and
source listen, prints that line, and fails when it is absent.
@coderabbitai
coderabbitai Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9e441202-bfd1-4557-8f90-6b470cf23b26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor Author

Approved: no findings at 0a8a6ab65afe.

Nothing to do.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The change conforms. On a VM node, §7.1 line 266 puts the dynamic-ingress decision in the host-side helper, and that helper audits it locally. The VM leg now asserts the host helper's box-admissions.log line for the listen. It fails when the line is absent, so the leg is hard, not not_run. The VM lane gives the run evidence. No condition is necessary.

Ruled at ae26c15 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 20, 2026
@norrietaylor
Copy link
Copy Markdown
Member

/revise
Fix the open minimal-review NIT in scripts/session-e2e.sh, proof_listen_published_port_reaches_peer_and_host: the || echo fallback never runs, because the pipeline's status is sed's, which is 0 when grep finds nothing. So a missing audit file prints no diagnostic. Capture the grep output first, and print the diagnostic when it is empty. Run shellcheck scripts/session-e2e.sh.

The || echo fallback never ran: the pipeline status was sed's, 0 even
when grep found nothing. Capture the grep output and print the fallback
when it is empty.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a /revise note, pushed as 0a8a6ab65afe.

line exit tail
bash scripts/session-e2e.sh listen_published_port_reaches_peer_and_host 0 ::warning::could not fetch the pinned gvproxy switch; native own-IP proofs will skip (stage /workbench/.scratch/gvproxy or install gvproxy-min under $MINIMAL_BIN) fetch-gvproxy: building gvproxy-linux-amd64 v0.9.0 from the pinned source build-gvproxy: downloading https://go.dev/dl/go1.26.10.linux-am

Verify min task run agent-verify passed.

Review threads the coder judged:

  • 👍 valid — scripts/session-e2e.sh:27597: Captured the box's host audit grep into a variable and print the '(no host audit line ...)' fallback when it is empty, so a missing audit file now prints the diagnostic.

On a KVM or macOS VM lane, listen_published_port_reaches_peer_and_host prints the host-held audit line for the listen's port and is not in the NOT RUN list. When the line is absent, the failure now prints the box's other host audit lines, or a line that says the audit file has none for the box.

Notes from the agent: Revise round 1: the fallback diagnostic now uses captured grep output and an explicit empty test, in place of the '|| echo' after the sed pipeline. I did not observe the VM leg: this box has no KVM and could not build the gvproxy switch, so the case skipped. The KVM or macOS VM lane owes the evidence for the proof.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

The VM-lane audit leg now asserts the listen's line in the host-held audit/box-admissions.log. Before, the leg was counted NOT RUN. Section 7.1 line 266 says the host-side helper decides the publish and audits it locally, so this is the correct record. The new commit only fixes the fallback that prints the box's lines when the match fails. The leg still fails closed. No conditions.

Ruled at 0a8a6ab against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — minimal-foundry[bot] scripts/session-e2e.sh. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-foundry minimal-foundry Bot removed the review:approved minimal-review approved the current head label Nov 21, 2026
@norrietaylor
Copy link
Copy Markdown
Member

/review

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approved

Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 0a8a6ab65afe withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.

@minimal-foundry minimal-foundry Bot added the review:approved minimal-review approved the current head label Nov 21, 2026
@norrietaylor norrietaylor left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate passes at 0a8a6ab: minimal-review approved, arch-review PASS, every lane aggregator green, no open threads.

@norrietaylor
norrietaylor added this pull request to the merge queue Nov 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 21, 2026
@norrietaylor
norrietaylor added this pull request to the merge queue Nov 21, 2026
Merged via the queue into main with commit 0b189af Nov 21, 2026
40 checks passed
@norrietaylor
norrietaylor deleted the agent/3698-on-a-vm-lane-the-session-e2e-asserts-a-listen-pu branch November 21, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:approved minimal-review approved the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The session e2e does not check a listen publication's decision record on VM lanes

1 participant

0