Repository navigation
fix: on a VM lane, the session e2e asserts a listen publication's decision record in the host-held - #3704
Conversation
On a VM lane, listen_published_port_reaches_peer_and_host no longer counts its audit leg NOT RUN. It reads the VM host daemon's audit/box-admissions.log for a line with the box, the listen's port and source listen, prints that line, and fails when it is absent.
|
Important Review skippedBot user detected. Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.
|
|
Approved: no findings at Nothing to do. Clobber: none seen. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The change conforms. On a VM node, §7.1 line 266 puts the dynamic-ingress decision in the host-side helper, and that helper audits it locally. The VM leg now asserts the host helper's box-admissions.log line for the listen. It fails when the line is absent, so the leg is hard, not not_run. The VM lane gives the run evidence. No condition is necessary.
Ruled at ae26c15 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.
|
/revise |
…ne-the-session-e2e-asserts-a-listen-pu
The || echo fallback never ran: the pipeline status was sed's, 0 even when grep found nothing. Capture the grep output and print the fallback when it is empty.
|
Round 1 of 10 on a /revise note, pushed as
Verify Review threads the coder judged:
On a KVM or macOS VM lane, listen_published_port_reaches_peer_and_host prints the host-held audit line for the listen's port and is not in the NOT RUN list. When the line is absent, the failure now prints the box's other host audit lines, or a line that says the audit file has none for the box. Notes from the agent: Revise round 1: the fallback diagnostic now uses captured grep output and an explicit empty test, in place of the '|| echo' after the sed pipeline. I did not observe the VM leg: this box has no KVM and could not build the gvproxy switch, so the case skipped. The KVM or macOS VM lane owes the evidence for the proof. |
There was a problem hiding this comment.
arch-review: PASS · the full ruling
The VM-lane audit leg now asserts the listen's line in the host-held audit/box-admissions.log. Before, the leg was counted NOT RUN. Section 7.1 line 266 says the host-side helper decides the publish and audits it locally, so this is the correct record. The new commit only fixes the fallback that prints the box's lines when the match fails. The leg still fails closed. No conditions.
Ruled at 0a8a6ab against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.
|
/review |
There was a problem hiding this comment.
minimal-review — approved
Verdict APPROVE — every review thread is resolved; @norrietaylor closed the last one. The review of 0a8a6ab65afe withheld this approval on the threads open then. Posted as a comment: the App cannot approve its own pull request; the check and the label carry it.
There was a problem hiding this comment.
Gate passes at 0a8a6ab: minimal-review approved, arch-review PASS, every lane aggregator green, no open threads.
Follow-up
Fixes #3698
scripts/session-e2e.shTask marker
Proof
On a KVM or macOS VM lane, listen_published_port_reaches_peer_and_host now reads $XDG_STATE_HOME/minimal/providers/local-minvmd0/audit/box-admissions.log, prints the 'host audit: {...}' line for box e2e-dyn-listen, port 18112, source listen, and fails when no such line arrives within 5 s. The VM-lane not_run for the audit leg is gone, so the case no longer appears in the NOT RUN list for that reason.
Notes from the agent: The VM leg is unverified here. This box has no KVM and no switch, so the test line skipped the whole case and exited 0. A KVM or macOS VM lane must supply the evidence. The match follows the existing expose leg (eib_vm_admission_line): the box name, the port followed by ',' or '}', and '"source":"listen"'. That is the serde snake_case form of PortReportSource::Listen in the AdmittedPortAudit record (crates/minvmd/src/control.rs). The read polls 20 times at 0.25 s because the host copy is written when the admission happens. The path assumes the default VM, local-minvmd0, the same one this case already uses for its boot log. The native lane's decisions.log leg is unchanged.
Tests
bash scripts/session-e2e.sh listen_published_port_reaches_peer_and_hostVerify
min task run agent-verifypassed ([tasks.verify]).