8000 fix(mfile,minimal): a box create sends the expanded spec with the client store rules, so a task's by minimal-foundry[bot] · Pull Request #3676 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(mfile,minimal): a box create sends the expanded spec with the client store rules, so a task's - #3676

Merged
mitodrummer merged 11 commits into
mainfrom
agent/3663-a-box-create-sends-the-expanded-spec-with-the-cl
Nov 20, 2026
Merged

mitodrummer merged 11 commits into
mainfrom
agent/3663-a-box-create-sends-the-expanded-spec-with-the-cl

Conversation

@minimal-foundry
@minimal-foundry minimal-foundry Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

Follow-up

Fixes #3663

Task marker
### D3377 — A box create sends the expanded spec with the client store rules, so a task's [secrets] reach its box and the client projection digest equals the daemon's
  kind: task
  size: M
  est: 200 code, 200 tests
  executor: agent
  origin: bug
  epic: 2236
  layers:
    - mfile:
      - crates/mfile/src/lib.rs: a task's `secrets` table is no longer reported as an unknown field (#3650)
      test: cargo test -p mfile secrets_entry_key_is_not_reported_unknown
    - client:
      - crates/minimal/src/cmd/boxes/create.rs: box_entry fills Layers::store_rules from read_client_config_and_store_rules. put_spec sends the expanded spec and sets the digest from Expansion::projection
      - crates/minimal/src/cmd/box_spec.rs: expand_entry for min box spec uses the same expansion and store rules as the create, and the Gap comment about #2410 goes away
      - crates/minimal/src/task.rs: put_task_spec sends the expanded task spec and its projection digest through the new put_spec form, so a task's `[secrets]` reach the daemon (#3650)
      - crates/minimal/src/tests.rs: tests: a broker secret on a task reaches the request spec, and on an un-enrolled host with no proxy `min task run` fails with exit 5 before a box exists
      test: cargo test -p minimal create_stores_a_client_digest_equal_to_the_daemon_digest
      test: cargo test -p minimal vpn_network_names_keep_the_client_digest_equal_to_the_daemon_digest
      test: cargo test -p minimal task_spec_carries_expanded_secrets
      test: cargo test -p minimal task_run_broker_secret_unenrolled_exits_5
  proof: For a session entry with a store-reference secret, the create request carries a client projection digest that equals mfile::projection::spec_digest of the sent spec, and the daemon stores both digests side by side. With [tasks.ci.secrets.GH_TOKEN] source = broker, min task run ci prints no unknown fields warning, and on an un-enrolled host with no proxy it exits 5 and no box is created.

Proof

For a session entry with a store-reference secret, the create request now carries the expanded [secrets], with the upstream and inject from the client's [secret-store-rules]. Its client projection digest equals mfile::projection::spec_digest of the sent spec, and it differs from the digest of the same spec without the rule. The daemon reads the sent spec back as a box spec with the secrets kept. With [tasks.ci.secrets.GH_TOKEN] source = "broker", loading minimal.toml prints no unknown fields warning, the task's spec carries the secret, and min task run ci on a host with no proxy exits 5 with the gatehouse_unenrolled_node refusal while the daemon lists no box.

Notes from the agent: Out of scope: crates/mfile/src/spec.rs. The daemon stores the sent spec JSON as given and reads it as mfile::spec::BoxSpec. SpecDoc uses deny_unknown_fields and had no secrets key, so a spec with [secrets] did not read back. That breaks the daemon's box name from the spec and the resume from the stored spec. The change keeps [secrets] whole in BoxSpec::kept_keys, the same as [nesting]. The client puts the expanded [secrets] there through the new put_expanded_spec.

Deviation: the digest is not computed from Expansion::projection. The daemon projects the v0 JSON that it receives, so the client still projects the sent spec (stamp_client_projection_digest). This keeps the two digests equal by construction, and the digest now binds the secrets. The task line asked for Expansion::projection. That projection reads the expanded table, not the v0 shape, and it is not guaranteed to equal the daemon's digest.

The proof says the daemon stores both digests side by side. The tests here pin only the client side. The daemon side is in minimald, which is not in the layers. The existing tests.rs::create_stores_client_digest_equal_to_daemon_digest still passes.

min task run sends no proxy root certificate. So the daemon refuses every brokered task secret. The client now refuses first with exi…[truncated]

Tests

line exit tail
cargo test -p mfile secrets_entry_key_is_not_reported_unknown 0 running 1 test test tests::secrets_entry_key_is_not_reported_unknown ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 229 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s warning: unk
cargo test -p minimal create_stores_a_client_digest_equal_to_the_daemon_digest 0 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 42 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 meas
cargo test -p minimal vpn_network_names_keep_the_client_digest_equal_to_the_daemon_digest 0 running 1 test test cmd::box_verbs::create::tests::vpn_network_names_keep_the_client_digest_equal_to_the_daemon_digest ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1051 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measur
cargo test -p minimal task_spec_carries_expanded_secrets 0 running 1 test test tests::task_spec_carries_expanded_secrets ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1051 filtered out; finished in 0.01s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 42 filtered out; finished in 0.00s running 0 tests
cargo test -p minimal task_run_broker_secret_unenrolled_exits_5 0 running 1 test test tests::task_run_broker_secret_unenrolled_exits_5 ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1051 filtered out; finished in 0.07s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 42 filtered out; finished in 0.00s running 0

Verify

min task run agent-verify exited 100, so this PR is a draft.

minimal::bin/min tests::invalid_project_file_for_box_spec_says_spec_cannot_show
        PASS [   0.008s] (1429/1454) minimal::bin/min tests::invalid_project_file_prints_toml_error_once
        PASS [   0.007s] (1430/1454) minimal::bin/min tests::loadout_not_found_exits_4
        PASS [   0.008s] (1431/1454) minimal::bin/min tests::invalid_project_file_prints_toml_error_once_for_io
        PASS [   0.007s] (1432/1454) minimal::bin/min tests::machine_mode_answers_write_failures
        PASS [   0.009s] (1433/1454) minimal::bin/min tests::local_host_not_found_exits_4
        PASS [   0.007s] (1434/1454) minimal::bin/min tests::machine_mode_error_line_keeps_an_empty_hint
        PASS [   0.012s] (1435/1454) minimal::bin/min tests::machine_mode_error_object_is_one_stamped_line
        PASS [   0.007s] (1436/1454) minimal::bin/min tests::machine_mode_error_object_on_stderr
        PASS [   2.065s] (1437/1454) minimal::named_vm named_vm_reaches_autospawn
        PASS [   0.006s] (1438/1454) minimal::bin/min tests::machine_output_mode_keys_on_the_output_flag
        PASS [   0.010s] (1439/1454) minimal::bin/min tests::machine_mode_names_the_grant_refusal_code
        PASS [   0.009s] (1440/1454) minimal::bin/min tests::misplaced_run_flag_exits_2
        PASS [   0.007s] (1441/1454) minimal::bin/min tests::network_flag_refusal_exits_2
        PASS [   0.007s] (1442/1454) minimal::bin/min tests::resume_and_session_attach_refusals_map_to_exit_codes
        PASS [   0.009s] (1443/1454) minimal::bin/min tests::prune_off_tty_needs_yes_exits_2
        PASS [   0.012s] (1444/1454) minimal::bin/min tests::project_file_not_found_exits_4
        PASS [   0.006s] (1445/1454) minimal::bin/min tests::session_policy_json_is_a_stdout_contract
        PASS [   0.013s] (1446/1454) minimal::bin/min tests::run_verbs_and_wait_timeout_return_124_with_code_timeout
        PASS [   0.014s] (1447/1454) minimal::bin/min tests::rm_running_box_refuses_naming_force_with_exit_2
        PASS [   0.009s] (1448/1454) minimal::bin/min tests::session_run_is_a_stdout_contract
        PASS [   0.009s] (1449/1454) minimal::bin/min tests::task_file_invalid_exits_3
        PASS [   0.013s] (1450/1454) minimal::bin/min tests::start_entry_refusals_exit_with_their_codes
        PASS [   0.009s] (1451/1454) minimal::bin/min tests::task_not_found_exits_4
        PASS [   0.009s] (1452/1454) minimal::bin/min tests::task_run_is_a_stdout_contract
        PASS [   0.009s] (1453/1454) minimal::bin/min tests::type_refusals_exit_3_and_4
  stdout ───

    running 1 test
    test exec_run_attach_and_task_run_share_the_commands_trace ... FAILED

    failures:

    failures:
        exec_run_attach_and_task_run_share_the_commands_trace

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5 filtered out; finished in 13.19s

  stderr ───

    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 
────────────
error: test run failed

Base

The base branch moved while the coder worked and was merged in before the tests ran. These files changed on BOTH sides since the branch point — read them first, because a rewrite from a stale reading can undo a merge without a conflict:

  • crates/minimal/src/cmd/box_spec.rs
  • crates/minimal/src/cmd/boxes/create.rs
  • crates/minimal/src/tests.rs

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/mfile/src/spec.rs

Residuals

Closes #3377 (the original issue this task was triaged from).
Closes #3650 (folded into this task on the owner ruling of 2026-11-19).

The entry expansion reads [tasks.<name>.secrets], so the load no longer
warns about it (#3650).
The session and task create paths expand the entry with the client's
secret-store rules and put the expanded [secrets] on the sent spec. The
stored spec keeps [secrets] whole, so the client projection digest binds
the grants and still equals the daemon's digest of the sent spec.
A task's [secrets] now reach the sent spec. Where no proxy serves boxes,
the run refuses each brokered secret with exit 5 before the create, as
the daemon refuses the same spec (#3650).
…te-sends-the-expanded-spec-with-the-cl

# Conflicts:
#	crates/minimal/src/cmd/boxes/create.rs
The create now sends the expanded spec, so dev's GitHub grant DEV_TOKEN
reaches the daemon. The daemon refuses that grant when no Box Egress
Proxy serves the box. The test now hands the proxy's root certificate,
as the activation does on a host with a proxy.
@coderabbitai
coderabbitai Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9b5b0b85-6e72-47db-bae2-2796472edbf3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

The stored spec now types [secrets], so the daemon reads a spec that
carries secrets and names an unnamed box after its entry (BOX-163).
The two projection digest tests created several unnamed boxes from one
entry, so the second create was refused for a held name. Each create
that files a record now takes its own request name.
…te-sends-the-expanded-spec-with-the-cl

# Conflicts:
#	crates/mfile/src/lib.rs
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a failed check suite, pushed as dfd8ecef8b26.

Resolved conflicts in: crates/mfile/src/lib.rs

line exit tail
cargo test -p mfile secrets_entry_key_is_not_reported_unknown 0 running 1 test test tests::secrets_entry_key_is_not_reported_unknown ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 230 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s warning: unk
cargo test -p minimal create_stores_a_client_digest_equal_to_the_daemon_digest 0 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 meas
cargo test -p minimal vpn_network_names_keep_the_client_digest_equal_to_the_daemon_digest 0 running 1 test test cmd::box_verbs::create::tests::vpn_network_names_keep_the_client_digest_equal_to_the_daemon_digest ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1066 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measur
cargo test -p minimal task_spec_carries_expanded_secrets 0 running 1 test test tests::task_spec_carries_expanded_secrets ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1066 filtered out; finished in 0.01s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 0.00s running 0 tests
cargo test -p minimal task_run_broker_secret_unenrolled_exits_5 0 running 1 test test tests::task_run_broker_secret_unenrolled_exits_5 ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1066 filtered out; finished in 0.04s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 0.00s running 0

Verify min task run agent-verify exited 125.

ize-0a8a7350b7e7e72e.rlib --extern stdlib=/work/build-cache/cargo-home/build/debug/deps/libstdlib-9905d85919a12313.rlib --extern switch=/work/build-cache/cargo-home/build/debug/deps/libswitch-6c812704e5da955c.rlib --extern sysinfo=/work/build-cache/cargo-home/build/debug/deps/libsysinfo-c713cd278cf33e00.rlib --extern tar=/work/build-cache/cargo-home/build/debug/deps/libtar-bb27b0a5d6ba0193.rlib --extern tempfile=/work/build-cache/cargo-home/build/debug/deps/libtempfile-a0e916d9301e1bc8.rlib --extern thiserror=/work/build-cache/cargo-home/build/debug/deps/libthiserror-d936554554fa5dac.rlib --extern tokio=/work/build-cache/cargo-home/build/debug/deps/libtokio-13fd64194b408f82.rlib --extern tokio_util=/work/build-cache/cargo-home/build/debug/deps/libtokio_util-55bfa9e349d7b2c1.rlib --extern tokio_vsock=/work/build-cache/cargo-home/build/debug/deps/libtokio_vsock-721a779abb11ee8a.rlib --extern tracing=/work/build-cache/cargo-home/build/debug/deps/libtracing-83feaaf26e80a884.rlib --extern tracing_appender=/work/build-cache/cargo-home/build/debug/deps/libtracing_appender-4049512b24d27abd.rlib --extern tracing_opentelemetry=/work/build-cache/cargo-home/build/debug/deps/libtracing_opentelemetry-4bc00377a5611f16.rlib --extern tracing_subscriber=/work/build-cache/cargo-home/build/debug/deps/libtracing_subscriber-b9d261067ec6d0c0.rlib --extern uuid=/work/build-cache/cargo-home/build/debug/deps/libuuid-2ad4c678aa627cb6.rlib --extern version=/work/build-cache/cargo-home/build/debug/deps/libversion-26aec4f378b53f65.rlib --extern vsock=/work/build-cache/cargo-home/build/debug/deps/libvsock-28a991460262852d.rlib --extern vt100=/work/build-cache/cargo-home/build/debug/deps/libvt100-cfaab5484d385f52.rlib --extern walkdir=/work/build-cache/cargo-home/build/debug/deps/libwalkdir-8278203427ac3159.rlib --extern zstd=/work/build-cache/cargo-home/build/debug/deps/libzstd-587a39a8eee416fb.rlib -L native=/work/build-cache/cargo-home/build/debug/build/tree-sitter-6abcf750100a3ada/out -L native=/work/build-cache/cargo-home/build/debug/build/tree-sitter-nickel-4d55240ed02e956b/out -L native=/work/build-cache/cargo-home/build/debug/build/zstd-sys-0d91391d9ed43bde/out -L native=/work/build-cache/cargo-home/build/debug/build/ring-43aedddb25fbb121/out -L native=/work/build-cache/cargo-home/build/debug/build/aws-lc-sys-467e076f78a0a3c4/out -L native=/work/build-cache/cargo-home/build/debug/build/blake3-493bdc0df5a171ff/out -L native=/work/build-cache/cargo-home/build/debug/build/blake3-493bdc0df5a171ff/out` (exit status: 101)
warning: build failed, waiting for other jobs to finish...
error: could not compile `minimal` (test "bug") due to 1 previous error
rustc-LLVM ERROR: IO failure on output stream: No space left on device
error: could not compile `minimal` (test "otel_cli")

Caused by:
writing stderr I/O error at path : No space left on device (os error 28)
error: sandbox command failed.
Kept box runtime-implement-verify-1. Remove it with min box rm runtime-implement-verify-1.

Outside the task's layers::

  • crates/mfile/src/spec.rs
  • crates/minimald/src/box_manager/tests.rs

Converted to a draft: verify exited 125; outside the task's layers:: crates/mfile/src/spec.rs, crates/minimald/src/box_manager/tests.rs.

For a session entry with a store-reference secret, the create request carries a client projection digest equal to mfile::projection::spec_digest of the sent spec, and the daemon stores both digests side by side. A task with [tasks.ci.secrets.GH_TOKEN] source = broker loads with no unknown fields warning, and on an un-enrolled host with no proxy min task run ci exits 5 and creates no box. The minimald projection digest tests now pass with the typed [secrets] section.

Notes from the agent: Revise round 1. The tests check failed in minimald: box_manager::tests::projection_digests_stored_side_by_side and projection_digest_mismatch_refuses_create. Cause: the earlier round added [secrets] to SpecDoc in crates/mfile/src/spec.rs (also outside the layers, needed so the stored spec keeps the secrets and the digests agree). The daemon can now read a spec that carries secrets, so creation_name names an unnamed box after its entry (BOX-163). Both tests created several unnamed boxes from one entry and relied on the old parse failure, so the second create got a held-name refusal. I confirmed this: both tests pass with main's spec.rs and fail with the branch's. The fix gives each create that files a record its own request name. This touches crates/minimald/src/box_manager/tests.rs, which is outside the layers. It is a test-only change. The product behaviour is correct. minimald-root-integration failed in apt (Unable to locate package protobuf-compiler), an infrastructure fault this branch cannot fix. ci-linux-native-success is the aggregator and fails because of the two jobs above. In this box three minimald env::tests fail or time out (task_entrypoint_carries_env_cwd_and_args, minenv_run_forwards_stdin_to_the_task, task_run_pipes_stdin_through_the_in_box_helper). task_entrypoint_carries_env_cwd_and_args fails with main's mfile too, so the box environment causes it. Under plain cargo test, tests::legacy_network_spellings_parse_with_hint fails because libtest captures e…[truncated]

@agent-137
agent-137 marked this pull request as ready for review November 20, 2026 03:37
@agent-137
agent-137 requested a review from a team as a code owner November 20, 2026 03:37
@minimal-foundry
minimal-foundry Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor Author

Reviewed: no findings; approval withheld, 1 thread unresolved at 319045afb33d.

APPROVE withheld: 1 u 8000 nresolved thread — minimal-arch[bot] crates/minimal/src/task.rs:1718. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The create and the task run now send the expanded [secrets] with the store rules written in. The client digest binds them, as architecture.md line 129 and line 1291 require. One gap has no owner. min task run sends no proxy root certificate, so the daemon refuses every brokered task secret, also on a host with a proxy. Principle 8 (line 338) gives a task box the same secrets as a session box, so this refusal is interim. Make the change in C1: file the issue and name it in task.rs.

Ruled at dfd8ece against gominimal/arch@8b824707cde6 by claude-opus-5-5.

expanded.as_ref().map(|expanded| &expanded.spec),
&args.other.vpn_network_names,
)?;
// BOX-081, #3650: the run sends no proxy root certificate. So where no
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · This run sends no root certificate, so the daemon refuses a brokered task secret on every host. A session box can use that secret. Principle 8 (architecture.md line 338) says capabilities do not follow the type. File an issue for the task path, name it here and in the doc at line 178, and mark this refusal as interim.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 319045afb33d: Named #3679 in the run_entry comment above refuse_unserved_broker_secrets(...) and in its doc, and marked the brokered task secret refusal as interim. No code path changed.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — minimal-arch[bot] crates/minimal/src/task.rs:1713. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@agent-137
Copy link
Copy Markdown
Member

/revise

Arch ruling PASS_WITH_CONDITIONS on dfd8ece (arch_rulings 1542). The mfile::spec::SpecDoc edit outside the layers is accepted. The residual is filed as #3679. Apply C1:

Keep the PR body's Closes #3377 and Closes #3650 lines. Under a ## Residuals heading in the body, add - #3679.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 319045afb33d.

line exit tail
cargo test -p mfile secrets_entry_key_is_not_reported_unknown 0 running 1 test test tests::secrets_entry_key_is_not_reported_unknown ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 230 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s warning: unk
cargo test -p minimal create_stores_a_client_digest_equal_to_the_daemon_digest 0 running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 18 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 meas
cargo test -p minimal vpn_network_names_keep_the_client_digest_equal_to_the_daemon_digest 0 running 1 test test cmd::box_verbs::create::tests::vpn_network_names_keep_the_client_digest_equal_to_the_daemon_digest ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1070 filtered out; finished in 0.00s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measur
cargo test -p minimal task_spec_carries_expanded_secrets 0 running 1 test test tests::task_spec_carries_expanded_secrets ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1070 filtered out; finished in 0.01s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 0.00s running 0 tests
cargo test -p minimal task_run_broker_secret_unenrolled_exits_5 0 running 1 test test tests::task_run_broker_secret_unenrolled_exits_5 ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 1070 filtered out; finished in 0.05s running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 0.00s running 0

Verify min task run agent-verify timed out after 1800s.

serial_test v4.0.1
    Checking minimal v0.8.0 (/workbench/crates/minimal)
    Finished `dev` profile [unoptimized] target(s) in 2m 02s
 Downloading crates ...
  Downloaded axum-core v0.5.6
  Downloaded aead v0.5.2
  Downloaded arbitrary v1.5.0
  Downloaded chacha20 v0.9.1
  Downloaded chacha20poly1305 v0.10.1
  Downloaded blake2 v0.10.6
  Downloaded cipher v0.4.4
  Downloaded boringtun v0.7.1
  Downloaded downcast v0.11.0
  Downloaded axum v0.8.9
  Downloaded curve25519-dalek v4.1.3
  Downloaded fragile v2.1.0
  Downloaded hmac v0.12.1
  Downloaded inout v0.1.4
  Downloaded ip_network_table-deps-treebitmap v0.5.0
  Downloaded ip_network_table v0.2.0
  Downloaded ip_network v0.4.1
  Downloaded matchit v0.8.4
  Downloaded multimap v0.10.1
  Downloaded mockall_derive v0.15.0
  Downloaded mockall v0.15.0
  Downloaded opaque-debug v0.3.1
  Downloaded poly1305 v0.8.0
  Downloaded predicates-core v1.0.10
  Downloaded predicates-tree v1.0.13
  Downloaded prettyplease v0.2.37
  Downloaded predicates v3.1.4
  Downloaded prost-build v0.14.4
  Downloaded pulldown-cmark-to-cmark v22.0.0
  Downloaded pulldown-cmark v0.13.6
  Downloaded termtree v0.5.1
  Downloaded tonic-build v0.14.6
  Downloaded tonic-prost-build v0.14.6
  Downloaded universal-hash v0.5.1
  Downloaded x25519-dalek v2.0.1
   Compiling opentelemetry v0.33.1
   Compiling version v0.8.0 (/workbench/crates/version)
   Compiling stdlib v0.0.22 (/workbench/crates/stdlib)
   Compiling serial_test v4.0.1
   Compiling opentelemetry_sdk v0.33.1
   Compiling tracing-opentelemetry v0.34.0
   Compiling opentelemetry-http v0.33.1
   Compiling opentelemetry-appender-tracing v0.33.1
   Compiling google-cloud-gax-internal v0.7.20
   Compiling opentelemetry-proto v0.33.0
   Compiling opentelemetry-otlp v0.33.0
   Compiling google-cloud-longrunning v1.14.0
   Compiling google-cloud-iam-v1 v1.13.0
   Compiling mlog v0.0.1 (/workbench/crates/mlog)
   Compiling google-cloud-lro v1.11.0
   Compiling google-cloud-storage v1.20.0
   Compiling common v0.0.1 (/workbench/crates/common)
   Compiling boxes v0.0.1 (/workbench/crates/boxes)
   Compiling sandbox v0.0.1 (/workbench/crates/sandbox)
   Compiling mfile v0.0.1 (/workbench/crates/mfile)
   Compiling minimald-rpc v0.0.1 (/workbench/crates/minimald-rpc)
   Compiling minvmd v0.8.0 (/workbench/crates/minvmd)
   Compiling minimal-client v0.8.0 (/workbench/crates/minimal-client)
   Compiling checkouts v0.0.1 (/workbench/crates/checkouts)
   Compiling decode v0.0.1 (/workbench/crates/decode)
   Compiling graph v0.0.1 (/workbench/crates/graph)
   Compiling lcache v0.0.1 (/workbench/crates/lcache)
   Compiling rcache v0.0.1 (/workbench/crates/rcache)
   Compiling op v0.0.1 (/workbench/crates/op)
   Compiling check v0.0.1 (/workbench/crates/check)
   Compiling orchestrator v0.0.1 (/workbench/crates/orchestrator)
   Compiling mctx v0.0.1 (/workbench/crates/mctx)
   Compiling minimald v0.8.0 (/workbench/crates/minimald)
   Compiling minimal v0.8.0 (/workbench/crates/minimal)

Outside the task's layers::

  • crates/mfile/src/spec.rs
  • crates/minimald/src/box_manager/tests.rs

Converted to a draft: verify timed out after 1800s.

Review threads the coder judged:

For a session entry with a store-reference secret, the create request carries a client projection digest that equals mfile::projection::spec_digest of the sent spec, and the daemon stores both digests side by side. With [tasks.ci.secrets.GH_TOKEN] source = broker, min task run ci prints no unknown fields warning, and on an un-enrolled host with no proxy it exits 5 and no box is created. This round, the comment above refuse_unserved_broker_secrets(...) in run_entry and the doc of that function name #3679 and mark the brokered task secret refusal as interim.

Notes from the agent: Revise round 2 applies C1 only. The change is comments and doc text in crates/minimal/src/task.rs, and no code path changes. The PR body edits (keep the Closes #3377 and Closes #3650 lines, add a ## Residuals heading with - #3679) belong to the runner, because the coder does not write the body.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 20, 2026 06:19
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS · the full ruling

C1 is met. The doc of refuse_unserved_broker_secrets and the comment in run_entry now name #3679. Both mark the refusal of a brokered task secret as interim. The merge from main does not change any hunk of this PR. The ruling at dfd8ecef stands for the rest of the change. The task path is still different from the session path, and #3679 tracks that residual.

Ruled at 319045a against gominimal/arch@8b824707cde6 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 1 unresolved thread — minimal-arch[bot] crates/minimal/src/task.rs:1718. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@agent-137
agent-137 marked this pull request as ready for review November 20, 2026 15:41
@mitodrummer mitodrummer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mitodrummer
mitodrummer added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit ef0b61b Nov 20, 2026
40 checks passed
@mitodrummer
mitodrummer deleted the agent/3663-a-box-create-sends-the-expanded-spec-with-the-cl branch November 20, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants

0