Repository navigation
fix(boxes): refuse the name self when a box is created - #3495
Open
bryan-minimal wants to merge 2 commits into
Open
bryan-minimal wants to merge 2 commits into
bryan-minimal wants to merge 2 commits into
Conversation
`self` addresses the calling box (BOX-007). A rename to it was refused, but the store filed a new box under it: the reserved-name list that creation reads did not carry it, so `min session activate --name self` made a box and published `self.min.internal`. Add the name to that list, from the one constant the rename check reads. A box already named `self` keeps working: a save that does not change the name does not read the list. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
Contributor
|
Approved: no findings at Nothing to do. Clobber: none seen. |
8000
div>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
selfis the name that addresses the calling box (BOX-007), so no box may take it. A rename toselfis refused. A creation was not:min session activate -n selfmade a box namedselfand publishedself.min.internal.The store's reserved-name list, which creation reads, did not carry the name. This adds it, from the one constant the rename check already reads.
Behaviour
self, in any case, is refused as an invalid name (`self` is reserved), and nothing is filed.BOX-007 words the refusal as exit 3. This change does not touch exit codes; creation answers as it does for the other reserved names.
Testing
self,SELFandSelfin a fresh store each, files nothing, and the same store then files an ordinary name; a record already namedselfcan still be saved.selfis created and listed; on this commit the creation is refused.🤖 Generated with Claude Code
Summary by CodeRabbit