Repository navigation
fix: fix(box): stop a task box's task containers with the box #3479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gominimal-aw-bot
wants to merge
19
commits into
main
Choose a base branch
from
inbox-patch/stop-task-containers-3521a49cbc7cb16e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,775
−16
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d90dde6
fix(box): stop a task box's task containers with the box
gominimal-aw-bot[bot] 92d0908
chore(worker-iterate): address CodeRabbit findings on PR #3479
gominimal-aw-bot[bot] e650c74
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer 0d66658
fix(box): refuse task containers while a box stops, and record every …
mitodrummer 4e81814
style(sandbox): log a refused process's kill and reap failures
mitodrummer f209f78
fix(sandbox): forget a task container's record as soon as it is reaped
mitodrummer d0c7f1e
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer 21e8fdf
fix(minimald): signal a task container through a pidfd pinned at spawn
mitodrummer 4743a06
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer 3d15944
fix(minimald): wait for a task run's exit before a stop signals the box
mitodrummer 41048ed
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer ac66d81
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer d092a1f
fix(minimald): pin each task container descendant before a stop signa…
mitodrummer ce59e97
fix(minimald): pin each process of a task container's tree during the…
mitodrummer 0e304cb
fix(box): refuse a task run begun during a stop, and reap before an o…
mitodrummer c2aaa63
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer e4dc328
8000
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer 83668d4
Merge origin/main into inbox-patch/stop-task-containers-3521a49cbc7cb16e
mitodrummer e8431f1
fix(box): signal a supervisor the scan missed; drop the hook value be…
mitodrummer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the relay wait after the exit line is written.
If
min box stoparrives afterend_task_runwritesexit:0but before the entrypoint reads it, the container record andTaskRunare both gone. This early return skips the relay wait.stop_box_processescan then send TERM to the live entrypoint, and the box can record a signal instead of exit 0.Track the active entrypoint’s exit handoff through relay completion, or retain enough state to apply the bounded relay wait after the write. Keep immediate force and the fast path for boxes with no entrypoint handoff.
Based on learnings, an empty task-container list does not prove the relay received the exit.
Source: Learnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked in #3626.